Bug 252601
| Summary: | games/devilutionX: fix empty "Show Credits" window | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Nuno Teixeira <eduardo> | ||||
| Component: | Individual Port(s) | Assignee: | Rainer Hurling <rhurlin> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | rhurlin | ||||
| Priority: | --- | Keywords: | buildisok | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/240376365 I bumped PORTREVISION. Did I did it right? Don't know who decides that, a commiter perhaps? Thanks (In reply to Nuno Teixeira from comment #2) I think you are right to bump portrevision, because the credits window becomes functional again. A commit references this bug: Author: rhurlin Date: Sat Jan 16 17:00:07 UTC 2021 New revision: 561738 URL: https://svnweb.freebsd.org/changeset/ports/561738 Log: games/devilutionX: fix empty credits window Fix empty "Show Credits" window by changing TTF_FONT_PATH to TTF_FONT_DIR/TTF_FONT_NAME, introduced in v1.1.0 [1]. [1] https://github.com/diasurgical/devilutionX/commit/791aa60cab453899dfaa7456cde1e8c23fcbee79 PR: 252601 Submitted by: Nuno Teixeira <ed.arrakis@gmail.com> (maintainer) Approved by: arrowd, tcberner (mentors, implicit) Changes: head/games/devilutionX/Makefile Committed, thanks :) |
Created attachment 221485 [details] Sugested git diff Fix empty "Show Credits" window: INFO: TTF_OpenFont: Couldn't open CharisSILB.ttf TTF_FONT_PATH was introduced in tag 1.0.1 to 1.0.3. 1.1.0 changed from TTF_FONT_PATH to TTF_FONT_DIR/TTF_FONT_NAME. (Based on inspecting CMakeLists.txt in all tags available) Thanks, Nuno Teixeira