Summary: | cad/PrusaSlicer: update to 2.3.0 | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | teodorsigaev <teodorsigaev> | ||||||||||||
Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||||||
Status: | Closed FIXED | ||||||||||||||
Severity: | Affects Many People | CC: | maciej | ||||||||||||
Priority: | --- | ||||||||||||||
Version: | Latest | ||||||||||||||
Hardware: | Any | ||||||||||||||
OS: | Any | ||||||||||||||
Attachments: |
|
Created attachment 221496 [details]
Diff to previous version of cad/PrusaSlicer
I can confirm that it builds for me and works fine, I'm printing a model sliced with PrusaSlicer-2.3.0 right now. Thank you! `make check-plist` reports that PrusaSlicer/bin/prusa-gcodeviewer (symlink to prusa-slicer) is not added to pkg-plist. Is this intentional? Created attachment 221533 [details]
full cad/PrusaSlicer directory
Fixed make check-plist
Created attachment 221534 [details]
Diff to previous version of cad/PrusaSlicer
Fixed make check-plist
(In reply to Maciej Pasternacki from comment #2) > `make check-plist` reports that PrusaSlicer/bin/prusa-gcodeviewer (symlink to prusa-slicer) is not added to pkg-plist. Is this intentional? No, itsn't intentional, just missed, thank you. Fixed. Created attachment 221546 [details]
Improved Patch
Let me suggest an improved patch.
- Whitespace fixes
- Remove duplicate (most of BUILD_DEPENDS) and unused (gtest, qt-buildtools) depends
- Add missing depends (png, desktop-file-utils)
- Use WX_CONFIG properly
- Support FHS
- Remove bogus post-patch
- Use DATADIR
- Install .desktop files into proper location
- Patch pthread_(get|set)_name_np in a way compatible with 11.x (the patch may be removed after 11.x EoL)
Thank you! Works for me. But qt5-buildtools dependency wasn't added by me, see https://svnweb.freebsd.org/ports/head/cad/PrusaSlicer/Makefile?revision=534388&view=markup And I a bit wonder why do you remove so many BUILD_DEPENDS entries? I'm afraid it will download itself instead of using ports versions if they aren't installed, see ./work/PrusaSlicer-version_2.3.0/deps/deps-unix-common.cmake and I don't think that is desired behavior. (In reply to teodorsigaev@gmail.com from comment #7) > And I a bit wonder why do you remove so many BUILD_DEPENDS entries? In fact I only did remove qt5-buildtools and gtest, other BUILD_DEPENDS were just duplicating LIB_DEPENDS or USES items. I've mailed mandree@ regarding qt-buildtools. > I'm afraid it will download itself instead of using ports versions if they aren't installed, see ./work/PrusaSlicer-version_2.3.0/deps/deps-unix-common.cmake and I don't think that is desired behavior. These external projects are not used during the build - they are aggregated into `deps` target which may be manually called to fetch and build depends. Also, if fetching during build ever happens, it would be catched by poudriere which prohibits such behavior. A commit references this bug: Author: amdmi3 Date: Fri Jan 15 00:24:13 UTC 2021 New revision: 561616 URL: https://svnweb.freebsd.org/changeset/ports/561616 Log: - Update to 2.3.0 [1] - Some port cleanup [2] - Whitespace fixes - Remove duplicate and unused depends - Add missing depends - Use WX_CONFIG properly - Support FHS - Switch to PORTDATA - Install .desktop files into proper location - Fix compatibility with 11.x PR: 252611 Submitted by: teodorsigaev@gmail.com (maintainer) [1], amdmi3 [2] Changes: head/cad/PrusaSlicer/Makefile head/cad/PrusaSlicer/distinfo head/cad/PrusaSlicer/files/patch-CMakeLists.txt head/cad/PrusaSlicer/files/patch-src_libslic3r_Thread.cpp head/cad/PrusaSlicer/files/patch-src_slic3r_CMakeLists.txt head/cad/PrusaSlicer/files/patch-src_slic3r_GUI_InstanceCheck.cpp head/cad/PrusaSlicer/pkg-plist Thank you very much! |
Created attachment 221495 [details] full cad/PrusaSlicer directory Update to recently released PrusaSlicer v2.3.0. Now PrusaSlicer use math/cgal port instead of builtin copy because port was updated to required version.