Bug 252805

Summary: devel/notcurses: allow using base ncurses
Product: Ports & Packages Reporter: Steve Wills <swills>
Component: Individual Port(s)Assignee: Steve Wills <swills>
Status: Closed Not Accepted    
Severity: Affects Only Me CC: nickblack
Priority: --- Flags: bugzilla: maintainer-feedback? (nickblack)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to make ports ncurses optional none

Description Steve Wills freebsd_committer freebsd_triage 2021-01-18 13:48:10 UTC
Created attachment 221707 [details]
patch to make ports ncurses optional

Ncurses is in base, but doesn't have a pkg-config file in base. Base ncurses is newer in newer releases. This patch allows using it if ports ncurses isn't installed.
Comment 1 nick black 2021-01-18 18:41:43 UTC
Comment on attachment 221707 [details]
patch to make ports ncurses optional

Seems reasonable to me, though I'm admittedly unsure what the difference is between the in-Base ncurses and ncurses Port. All I need from either is a working terminfo library and database.

If `notcurses-tester` and `notcurses-demo` still work well following this change, go for it!
Comment 2 Steve Wills freebsd_committer freebsd_triage 2021-01-19 20:27:51 UTC
(In reply to Nick Black from comment #1)
Thanks for pointing those out. I discovered a problem in my port Makefile patch, which I fixed, which lead me to discover that the base libtinfo is a symlink to the base libncursesw which contains conflicting symbols with notcurses, so this may not be workable for now.
Comment 3 Steve Wills freebsd_committer freebsd_triage 2021-01-19 22:18:07 UTC
This just isn't workable right now. Maybe if we can fix ncurses in base we can revisit this another time. Closing for now.