Summary: | [New Port] misc/wmforecast: Weather dockapp for Window Maker using the Yahoo Weather API | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Igor Pokrovsky <obscenum999> | ||||||
Component: | Individual Port(s) | Assignee: | Rainer Hurling <rhurlin> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | obscenum999, rhurlin | ||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://github.com/d-torrance/wmforecast/blob/master/ChangeLog | ||||||||
Attachments: |
|
Description
Igor Pokrovsky
2021-01-18 18:21:53 UTC
Created attachment 221730 [details]
patch with some corrections of initial version
Hi Igor,
Many thanks for this nice little new port!
After I investigated a bit in some test, I suggest an updated patch (see attachment area) with the following changes:
- Removing [SPACE] before the TAB in lines 4,5,6, and 7
- Adding USES=pkgconfig
- Adding INSTALLS_ICONS=yes
- Adding OPTION NLS for users, who have no need
to build with gettext
- Remove PORT_OPTIONS=MGEOCLUE, not used for anything
- Add GEOCLUE_CONFIGURE_WITH=geoclue. Otherwise the port
uses geoclue, if installed, even when unselected.
- Reorder some vars in Makefile, as suggested by
portclippy (from ports-mgmt/portfmt)
- Add Desktop files to pkg-plist
If you agree with my changes, could you please give approval to the patch (= changing the field in attachment area right to the patch from '?' to '+')?
Comment on attachment 221730 [details]
patch with some corrections of initial version
Hello Rainer,
Thank you very much for your corrections! Last time I ported apps about 10 years ago, much has changed since that time. I guess I have to learn new things.
This is the only WM dock app, that actually works for me. Other weather dock apps from ports don't.
(In reply to Igor Pokrovsky from comment #2) FYI: I just opened a review on Phabricator [1], to get approval from my mentors ;) [1] https://reviews.freebsd.org/D28239 I am successfully running misc/wmweather+ for years now. It needs a configuration file 'EDDV.conf' under ~/.wmweather+, in my case with the following contents: email xxxx@xxxx.xx station EDDV location xx'xx'xxN xx'xx'xxE kph tempc HTH, Rainer A commit references this bug: Author: rhurlin Date: Tue Jan 19 19:01:08 UTC 2021 New revision: 562070 URL: https://svnweb.freebsd.org/changeset/ports/562070 Log: misc/wmforecast: New port, version 1.4 Wmforecast, a weather dockapp for Window Maker, displays current temperature and current conditions. Forecast via balloon tooltip. Changelog: https://github.com/d-torrance/wmforecast/blob/master/ChangeLog PR: 252811 Submitted by: Igor Pokrovsky <ip@unixway.org> (new maintainer) Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D28239 Changes: head/misc/Makefile head/misc/wmforecast/ head/misc/wmforecast/Makefile head/misc/wmforecast/distinfo head/misc/wmforecast/pkg-descr head/misc/wmforecast/pkg-plist Committed, congrats and thanks :) Thanks, Rainer! |