Summary: | devel/zziplib: add MANPAGES and TEST options | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||||||
Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Only Me | CC: | diizzy, pi, tcberner | ||||||||
Priority: | --- | Flags: | tcberner:
maintainer-feedback-
|
||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
URL: | https://github.com/gdraheim/zziplib/releases/tag/v0.13.72 | ||||||||||
Attachments: |
|
Description
Daniel Engberg
2021-01-20 15:54:42 UTC
Patches are to keep the same namning for libraries as autotools. Ping? Hi Sunpoet, Can you have a look at the current committed version? pkgconfig is required https://github.com/gdraheim/zziplib/blob/master/bins/CMakeLists.txt#L9 Tests requires zip as far as I can tell https://github.com/gdraheim/zziplib/blob/master/test/CMakeLists.txt#L23 https://github.com/gdraheim/zziplib/blob/master/test/zziptests.py#L33 Not disabling ZZIP_TESTCVE will cause external downloads during testing https://github.com/gdraheim/zziplib/blob/master/test/CMakeLists.txt#L33 It would also be nice to have manpages optional Regards, Daniel Maintainer timeout https://svnweb.freebsd.org/changeset/ports/567618 has the update to 0.13.72 Hi Kurt, I know but it's broken... See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252862#c3 Created attachment 223372 [details]
Patch for zziplib
This should fix issues in committed version
Kurt, Can you have a look at this? (In reply to daniel.engberg.lists from comment #8) Builds OK with options MANPAGES, SDL. Still fails to build with option TEST, at least on HEAD. More testbuilding right now. Ahh, it doesn't pull in zip during build (I already had it installed on my system) Not sure if we should set both TEST_BUILD_DEPENDS= zip:archivers/zip and TEST_DEPENDS= zip:archivers/zip though Best regards, Daniel Created attachment 223458 [details]
Patch for zziplib v2
Fix make test build dependency
(In reply to daniel.engberg.lists from comment #11) testbuilds are fine make test ran fine on 14.0-main-c256294-g2cf84258922f Thanks Kurt, can you commit it due to timeout? I'll take a look when available. I see nothing wrong without pkgconfig. What failure did you get? Configure stage throws some errors however it does complete -- installing zzip pkgconfig files: ON -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) -- Checking for one of the modules 'zzip' -- lib zzipwrap symlinks as by libtool: ON -- installing zzipwrap pkgconfig files: ON -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) A commit references this bug: Author: sunpoet Date: Tue Mar 30 19:16:37 UTC 2021 New revision: 569583 URL: https://svnweb.freebsd.org/changeset/ports/569583 Log: Add MANPAGES and TEST options - Bump PORTREVISION for package change PR: 252862 Submitted by: Daniel Engberg <daniel.engberg.lists@pyret.net> Changes: head/devel/zziplib/Makefile head/devel/zziplib/pkg-plist Committed. Thanks! |