Summary: | databases/tcl-sqlite3: Update to 3.34.1 | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Pavel Volkov <pavelivolkov> | ||||||||||
Component: | Individual Port(s) | Assignee: | Lewis Cook <lcook> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Only Me | CC: | lcook, pavelivolkov | ||||||||||
Priority: | --- | Keywords: | buildisok | ||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252963 | ||||||||||||
Attachments: |
|
Description
Pavel Volkov
2021-01-24 07:03:59 UTC
Created attachment 221868 [details]
poudriere log
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/246009560 Moin moin, thank you for the submission. Just one minor nit: $ portclippy Makefile PORTNAME PORTVERSION CATEGORIES MASTER_SITES PKGNAMEPREFIX DISTNAME # Maintainer block MAINTAINER COMMENT # License block LICENSE # Dependencies LIB_DEPENDS # USES block USES USE_LDCONFIG # Configure block +CONFIGURE_ARGS -OPTIONS_DEFINE -OPTIONS_DEFAULT -WRKSRC # CFLAGS/CXXFLAGS/LDFLAGS block CFLAGS LDFLAGS # Standard bsd.port.mk variables +SUB_FILES +SUB_LIST -CONFIGURE_ARGS # WRKSRC block +WRKSRC -THREADS_CONFIGURE_ENABLE # Packaging list block PLIST_FILES PORTEXAMPLES # Options definitions +OPTIONS_DEFINE +OPTIONS_DEFAULT # Options helpers +THREADS_CONFIGURE_ENABLE -SUB_FILES -SUB_LIST Would you mind re-ordering the variables as suggested by portclippy[1]? otherwise everything else looks fine. Thanks! [1] https://www.freshports.org/ports-mgmt/portfmt - portclippy is part of the portfmt test-suite Created attachment 222018 [details]
patch
Path with ordered variables.
Created attachment 222019 [details]
poudriere log
A commit references this bug: Author: lcook Date: Sat Jan 30 16:32:58 UTC 2021 New revision: 563421 URL: https://svnweb.freebsd.org/changeset/ports/563421 Log: databases/tcl-sqlite3: Update to 3.34.1 While here, pet portclippy. Changes: https://www.sqlite.org/releaselog/3_34_1.html PR: 252964 Submitted by: Pavel Volkov <pavelivolkov@gmail.com> (maintainer) Approved by: tcberner (mentor) Differential Revision: https://reviews.freebsd.org/D28426 Changes: head/databases/tcl-sqlite3/Makefile head/databases/tcl-sqlite3/distinfo Committed with minor changes, thanks! |