Bug 252988

Summary: security/gopass: Adopt and Update to 1.11.0
Product: Ports & Packages Reporter: Nuno Teixeira <eduardo>
Component: Individual Port(s)Assignee: Dmitri Goutnik <dmgk>
Status: Closed FIXED    
Severity: Affects Only Me CC: dmgk, fernape
Priority: --- Keywords: buildisok
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/gopasspw/gopass/compare/v1.8.6...v1.11.0
Attachments:
Description Flags
Sugested gitt diff
eduardo: maintainer-approval-
Sugested git diff (completion + docs)
eduardo: maintainer-approval+
Sugested git diff (final)
eduardo: maintainer-approval-
gopass-1.11.0.patch dmgk: maintainer-approval?

Description Nuno Teixeira freebsd_committer freebsd_triage 2021-01-25 08:16:00 UTC 
Created attachment 221894 [details]
Sugested gitt diff

Hello,

security/gopass: Adopt and Update to 1.11.0 version

- Added DOCS (README.md)
- removed bash and zsh completions to simplify port and because gopass offers completions to users:
//
NAME:
   gopass completion - Bash and ZSH completion

USAGE:
   gopass completion command [command options] [arguments...]

DESCRIPTION:
   Source the output of this command with bash or zsh to get auto completion

COMMANDS:
   bash        Source for auto completion in bash
   zsh         Source for auto completion in zsh
   fish        Source for auto completion in fish
   openbsdksh  Source for auto completion in OpenBSD's ksh
   help, h     Shows a list of commands or help for one command
//
- It was cool to add gopass exemples from this repository: https://github.com/gopasspw/password-store-example , but I don't know how to fetch it to include in port.
- I've tested building gopass on 12.2 i386 but some gopass internal modules fails to compile, so this is only for amd64 arch

Thanks,

Nuno Teixeira
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2021-01-25 08:19:49 UTC 
and
- updated WWW
Comment 2 Automation User 2021-01-25 08:59:41 UTC 
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/246286706
Comment 3 Dmitri Goutnik freebsd_committer freebsd_triage 2021-01-25 13:51:07 UTC 
Hi,

Thanks for adopting this port. A few notes:

- It is still possible to generate and install shell completion files, please see e.g. devel/golangci-lint post-build and post-install targets for an example. Previous port version installed completion files, I think it would make sense to keep providing them.

- Distfile has a bunch of documentation is the "docs" directory, shouldn't it be installed as well?
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2021-01-26 09:12:52 UTC 
Created attachment 221926 [details]
Sugested git diff (completion + docs)

Hi,

- Added completion (bash, fish and zsh)
- Added ${WRKSRC}/docs/* (including ${WRKSRC}/README.md)

Any chance to add EXAMPLES from other repository?
https://github.com/gopasspw/password-store-example

I don't know how to fetch it.

Thanks,

Nuno
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2021-01-26 10:37:48 UTC 
Found it:

5.4.3.1. Fetching Multiple Files from GitHub

Please do not commit last patch, I will try to fetch EXAMPLES.

Thanks
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2021-01-26 12:55:14 UTC 
Created attachment 221929 [details]
Sugested git diff (final)

Hi,

This is the patch without fetching examples from https://github.com/gopasspw/password-store-example:

GH_PROJECT=     password-store-example:examples
GH_TAGNAME=     8db75ba:examples
GH_SUBDIR=      password-store-example:examples

If I include this 3 lines in Makefile they broke:

${SETENV} ${MAKE_ENV} ${GO_ENV} ${GO_WRKDIR_BIN}/${PORTNAME} completion ${SHELL} > ${GO_WRKSRC}/${SHELL} : gopass not found.

A bug?

The strange is that extract ok password-store-example into wrksrc.
But make fails.
Its not to important thing not include this extra examples, but I can't figured out whats wrong.

Thanks
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2021-01-26 13:00:26 UTC 
Comment on attachment 221926 [details]
Sugested git diff (completion + docs)

Better use this one
Comment 8 Dmitri Goutnik freebsd_committer freebsd_triage 2021-01-26 14:06:09 UTC 
Created attachment 221935 [details]
gopass-1.11.0.patch

(In reply to Nuno Teixeira from comment #6)
Hi Nuno,

> A bug?

When you set GH_PROJECT like this, you override its default value "gopass", and this breaks the build. Instead, password-store-example can be just added to the GH_TUPLE:

GH_TUPLE+=  gopasspw:password-store-example:8db75ba3b69c:password_store_example

Also, "Sugested git diff (final)" seems to be missing pkg-plist (forgotten `svn add`?).

I added examples and pkg-plist, please see attached patch.
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2021-01-26 14:35:35 UTC 
Comment on attachment 221935 [details]
gopass-1.11.0.patch

Thanks and sorry for my first atempt :)

Can you check if pkp-plist is ok?

It reinstall with some warnings: pkg-static: duplicate file listing, but install/deinstall ok.

Thanks,

Nuno
Comment 10 Dmitri Goutnik freebsd_committer freebsd_triage 2021-01-26 15:42:07 UTC 
Please make sure that your local pkg-plist is the same as in the attached patch. You must have some local modifications because `poudriere testport` passes without warnings here.
Comment 11 Nuno Teixeira freebsd_committer freebsd_triage 2021-01-26 17:20:37 UTC 
ok, I will try to figured it out.

This patch looks good, will you commit?

Thanks,

Nuno
Comment 12 commit-hook freebsd_committer freebsd_triage 2021-01-26 18:53:47 UTC 
A commit references this bug:

Author: dmgk
Date: Tue Jan 26 18:53:14 UTC 2021
New revision: 562976
URL: https://svnweb.freebsd.org/changeset/ports/562976

Log:
  security/gopass: Update to 1.11.0

  - Update to 1.11.0
  - Pass maintainership to the submitter

  Changes:	https://github.com/gopasspw/gopass/releases/tag/v1.11.0
  PR:		252988
  Submitted by:	Nuno Teixeira <ed.arrakis@gmail.com>

Changes:
  head/security/gopass/Makefile
  head/security/gopass/distinfo
  head/security/gopass/files/
  head/security/gopass/pkg-descr
  head/security/gopass/pkg-plist
Comment 13 commit-hook freebsd_committer freebsd_triage 2021-01-26 18:55:48 UTC 
A commit references this bug:

Author: dmgk
Date: Tue Jan 26 18:55:10 UTC 2021
New revision: 562978
URL: https://svnweb.freebsd.org/changeset/ports/562978

Log:
  MFH: r562976

  security/gopass: Update to 1.11.0

  - Update to 1.11.0
  - Pass maintainership to the submitter

  Changes:	https://github.com/gopasspw/gopass/releases/tag/v1.11.0
  PR:		252988
  Submitted by:	Nuno Teixeira <ed.arrakis@gmail.com>

Changes:
_U  branches/2021Q1/
  branches/2021Q1/security/gopass/Makefile
  branches/2021Q1/security/gopass/distinfo
  branches/2021Q1/security/gopass/files/
  branches/2021Q1/security/gopass/pkg-descr
  branches/2021Q1/security/gopass/pkg-plist
Comment 14 Dmitri Goutnik freebsd_committer freebsd_triage 2021-01-26 18:57:17 UTC 
Committed, thanks!