Bug 253036

Summary: www/firefox: add LTO option
Product: Ports & Packages Reporter: Piotr Kubaj <pkubaj>
Component: Individual Port(s)Assignee: freebsd-gecko (Nobody) <gecko>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy
Priority: --- Flags: bugzilla: maintainer-feedback? (gecko)
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253539
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253771
Attachments:
Description Flags
patch none

Description Piotr Kubaj freebsd_committer freebsd_triage 2021-01-27 00:14:46 UTC
Created attachment 221950 [details]
patch

For some reason, I was unable to build Firefox with LTO on 12.2-RELEASE, but it works on 13.0-ALPHA2 (both amd64).

On 12.2-RELEASE, build times out.

I did not yet test thunderbird or firefox-esr.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-01-27 00:47:53 UTC
Can we add LTO_DESC to Mk/bsd.options.desc.mk as we're getting more and more ports that uses it?

https://svnweb.freebsd.org/ports/head/net-mgmt/netdata/Makefile?revision=559848&view=markup#l79
https://svnweb.freebsd.org/ports/head/multimedia/ffmpeg/Makefile?revision=559263&view=markup#l108

Are at least two I know off the top of my head
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2021-01-27 18:27:31 UTC
If I get approval for adding LTO option here, I'll change options for other ports. On top of my head, wireshark also has (or had) LTO option.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-02-10 19:24:37 UTC
A commit references this bug:

Author: pkubaj
Date: Wed Feb 10 19:23:51 UTC 2021
New revision: 564901
URL: https://svnweb.freebsd.org/changeset/ports/564901

Log:
  www/firefox: add LTO option

  PR:		253036
  Approved by:	gecko (maintainer timeout)

Changes:
  head/Mk/bsd.gecko.mk
  head/www/firefox/Makefile.options