Bug 253285

Summary: x11/nvidia-driver not PREFIX-safe
Product: Ports & Packages Reporter: Mikhail Teterin <mi>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Closed FIXED    
Severity: Affects Some People CC: danfe, david, iwtcex, kbowling, pi
Priority: --- Flags: bugzilla: maintainer-feedback? (danfe)
kbowling: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
vulkan icd cleanup iwtcex: maintainer-approval? (danfe)

Description Mikhail Teterin freebsd_committer freebsd_triage 2021-02-06 05:52:35 UTC 
My PREFIX is /opt, and most of the files are staged correctly -- under work/stage/opt -- except:

share/vulkan/icd.d/nvidia_icd.json
share/vulkan/implicit_layer.d/nvidia_layers.json

For some reason, the above two end up under work/stage/usr/local/
Comment 1 david 2021-02-08 18:10:01 UTC 
I see similar results for a machine where I do not change PREFIX, but where I have:

PORTSDIR=/common/ports
Comment 2 Alex S 2021-06-29 15:16:58 UTC 
Created attachment 226115 [details]
vulkan icd cleanup

I don't know about "most files" being staged correctly, but here is the patch fixing an annoying inconsistency between vulkan and egl icd parts of this port.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-08-02 23:17:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ec9fff767494883b0dc6b677c9a00a516f9df045

commit ec9fff767494883b0dc6b677c9a00a516f9df045
Author:     Alex S <iwtcex@gmail.com>
AuthorDate: 2021-08-02 23:13:40 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-08-02 23:13:40 +0000

    x11/nvidia-driver: make vulkan PREFIX safe

    PR:             253285
    Reported by:    mi
    Approved by:    danfe (maintainer)

 x11/nvidia-driver/Makefile                         |  9 +++++---
 .../460-patch-lib-libGLX_nvidia-Makefile (gone)    | 27 ----------------------
 2 files changed, 6 insertions(+), 30 deletions(-)
Comment 4 Kevin Bowling freebsd_committer freebsd_triage 2021-08-02 23:18:44 UTC 
Thanks for your contribution!
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-08-02 23:19:56 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2dd724a0cab2d45321ac5ade9517b4464ef1b440

commit 2dd724a0cab2d45321ac5ade9517b4464ef1b440
Author:     Alex S <iwtcex@gmail.com>
AuthorDate: 2021-08-02 23:13:40 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-08-02 23:18:09 +0000

    x11/nvidia-driver: make vulkan PREFIX safe

    PR:             253285
    Reported by:    mi
    Approved by:    danfe (maintainer)

    (cherry picked from commit ec9fff767494883b0dc6b677c9a00a516f9df045)

 x11/nvidia-driver/Makefile                         |  9 +++++---
 .../460-patch-lib-libGLX_nvidia-Makefile (gone)    | 27 ----------------------
 2 files changed, 6 insertions(+), 30 deletions(-)