Bug 253377

Summary: multimedia/butt: update 0.1.27 -> 0.1.40
Product: Ports & Packages Reporter: Per Gunnarsson <per>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Only Me CC: diizzy, per
Priority: --- Keywords: buildisok
Version: LatestFlags: pi: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
diff multimedia/butt multimedia/butt-0.1.28
none
Tried to make a new patch for 1.35
none
additional patches were supposed to be included
none
Now this last patch is dubious
none
patch none

Description Per Gunnarsson 2021-02-09 16:25:46 UTC
Created attachment 222296 [details]
diff multimedia/butt multimedia/butt-0.1.28
Comment 1 Automation User 2021-02-24 11:16:18 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/260994392
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-08-09 08:12:32 UTC
Hi,

Is this compile and/or runtime tested?

Best regards,
Daniel
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2022-08-09 08:17:18 UTC
Not by me. So if someone wants to take a look ? The latest at upstream is 0.1.35
Comment 4 Per Gunnarsson 2022-08-09 16:53:13 UTC
Created attachment 235808 [details]
Tried to make a new patch for 1.35
Comment 5 Per Gunnarsson 2022-08-09 17:00:41 UTC
Comment on attachment 235808 [details]
Tried to make a new patch for 1.35

I have compiled it but could not test it because of problems with portaudio.
The interface comes up and it seems to work with basic "OSS" devices.

My own setup needs jack, pulseaudio and portaudio.
Comment 6 Per Gunnarsson 2022-08-12 13:19:09 UTC
Created attachment 235861 [details]
additional patches were supposed to be included
Comment 7 Per Gunnarsson 2022-08-12 13:21:31 UTC
Created attachment 235862 [details]
Now this last patch is dubious

I randomly inclided limits.h with little knowledge about the entry just to make the compile process proceed.
Comment 8 Per Gunnarsson 2022-08-12 13:25:08 UTC
Now it compiles, the interface comes up and it works with icecast but uses a lot of CPU.
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2022-09-27 10:09:15 UTC
Hi,

Have you tried contacting upstream about it?

ffmpeg might be an alternative otherwise

Best regards,
Daniel
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2022-12-27 20:22:52 UTC
Created attachment 239070 [details]
patch

testbuilds@work
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2022-12-27 20:44:40 UTC
Can someone who uses this port do a run-test ?
Comment 12 Per Gunnarsson 2023-01-14 22:01:45 UTC
I tried to apply the patch and when compiling I get:

FLTK/fl_funcs.cpp:662:42: error: use of undeclared identifier 'PATH_MAX'
    expanded_rec_folder = (char *)malloc(PATH_MAX * sizeof(char));
                                         ^
FLTK/fl_funcs.cpp:665:45: error: use of undeclared identifier 'PATH_MAX'
    fl_filename_expand(expanded_rec_folder, PATH_MAX, cfg.rec.folder);

Last time I tried I got around it by including limits.h

PATH_MAX seems defined in /sys/sys/syslimits.h on FreeBSD

I will ask Daniel Noethen about this.
Comment 13 Kurt Jaeger freebsd_committer freebsd_triage 2024-03-16 20:06:11 UTC
Hmm, distfiles for 0.1.40 are not available on sourceforge.
Comment 14 Kurt Jaeger freebsd_committer freebsd_triage 2024-03-16 21:20:03 UTC
(In reply to Kurt Jaeger from comment #13)
thanks to author, found it on his website. No SF distribution anymore.
Comment 15 commit-hook freebsd_committer freebsd_triage 2024-03-16 21:30:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3e9a8d8c519234c24f1fe12cdd7adeb8dfee0557

commit 3e9a8d8c519234c24f1fe12cdd7adeb8dfee0557
Author:     Kurt Jaeger <pi@FreeBSD.org>
AuthorDate: 2024-03-16 21:28:51 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2024-03-16 21:29:16 +0000

    multimedia/butt: update 0.1.27 -> 0.1.40

    PR:             253377
    Changes:        https://danielnoethen.de/butt/Changelog.html

 multimedia/butt/Makefile                                | 17 ++++++++++++-----
 multimedia/butt/distinfo                                |  6 +++---
 .../butt/files/patch-src_FLTK_fl__funcs.cpp (new)       | 10 ++++++++++
 multimedia/butt/files/patch-src_Makefile.am             |  8 --------
 4 files changed, 25 insertions(+), 16 deletions(-)
Comment 16 Kurt Jaeger freebsd_committer freebsd_triage 2024-03-16 21:30:55 UTC
Committed version 0.1.40.