Bug 253438

Summary: devel/jenkins & devel/jenkins-lts: Add newsyslog configuration
Product: Ports & Packages Reporter: Brad Davis <brd>
Component: Individual Port(s)Assignee: Li-Wen Hsu <lwhsu>
Status: In Progress ---    
Severity: Affects Only Me CC: lwhsu, ohauer
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch none

Description Brad Davis freebsd_committer 2021-02-11 17:08:32 UTC
Created attachment 222371 [details]
patch

This follows the path of what the Jenkins packages for other OSes do[1].

1: https://github.com/jenkinsci/jenkins/commit/8b09a585243287b6cb5270a0a1447995f1fc3dff
Comment 1 Li-Wen Hsu freebsd_committer 2021-02-11 17:20:49 UTC
Looks good to me. Wait for reply from swills.
Comment 2 Brad Davis freebsd_committer 2021-03-30 15:23:23 UTC
Can I commit now that you own both?
Comment 3 Li-Wen Hsu freebsd_committer 2021-03-30 15:45:06 UTC
I'm fine with it. OTOH, I'm thinking maybe it's also good to install as a sample file and notice user in the pkg-message. What do you think about this?
Comment 4 Olli Hauer freebsd_committer 2021-06-16 12:31:09 UTC
I agree with Li-Wen-Hsu to install as sample file, e.g. I'm haveing a different rotate scedule and it would be nice to not overwrite it all the time jenkins is updated

Additional it would be nice to use the official --logfile parameter, see bug #256644
Comment 5 Li-Wen Hsu freebsd_committer 2021-06-20 03:29:50 UTC
I'm testing this, however, I found that it seems we cannot just use this newsyslog setting.  If we don't specify pid_file, the process will not be aware of fd changed and there will be no new log appended until restart.  If we add pid_file, the default HUP signal will stop the Jenkins process.  I'm still finding if there is other solution.

Note that the patch in comment #0 is using "copytruncate" as workaround.