Bug 253576

Summary: lang/go: Update to 1.16
Product: Ports & Packages Reporter: Felix Hanley <felix>
Component: Individual Port(s)Assignee: Dmitri Goutnik <dmgk>
Status: Closed FIXED    
Severity: Affects Only Me CC: felix
Priority: --- Flags: bugzilla: maintainer-feedback? (dmgk)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://blog.golang.org/go1.16
Attachments:
Description Flags
Update patch none

Description Felix Hanley 2021-02-17 05:06:52 UTC 
Created attachment 222507 [details]
Update patch

Update to 1.16 and removes required patch. See https://blog.golang.org/go1.16
Comment 1 Dmitri Goutnik freebsd_committer freebsd_triage 2021-02-17 11:56:45 UTC 
Fixed by ports r565496
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-02-25 18:21:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=2593f858d7d078efa85f78f20b6bfa0931cc1dc5

commit 2593f858d7d078efa85f78f20b6bfa0931cc1dc5
Author:     Richard Scheffenegger <rscheff@FreeBSD.org>
AuthorDate: 2021-02-25 18:10:55 +0000
Commit:     Richard Scheffenegger <rscheff@FreeBSD.org>
CommitDate: 2021-02-25 18:12:20 +0000

    A TCP server has to take into consideration, if TCP_NOOPT is preventing
    the negotiation of TCP features. This affects most TCP options but
    adherance to RFC7323 with the timestamp option will prevent a session
    from getting established.

    PR:     253576
    Reviewed By:    tuexen, #transport
    MFC after:      3 days
    Sponsored by:   NetApp, Inc.
    Differential Revision: https://reviews.freebsd.org/D28652

 sys/netinet/tcp_input.c    | 12 ++++++++----
 sys/netinet/tcp_syncache.c |  3 ++-
 2 files changed, 10 insertions(+), 5 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-02-28 08:22:42 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c0c928636156dd913302bc34e5ac9d70810f5cdd

commit c0c928636156dd913302bc34e5ac9d70810f5cdd
Author:     Richard Scheffenegger <rscheff@FreeBSD.org>
AuthorDate: 2021-02-25 18:10:55 +0000
Commit:     Richard Scheffenegger <rscheff@FreeBSD.org>
CommitDate: 2021-02-28 08:11:18 +0000

    TCP_NOOPT may prevent the negotiation of TCP features, which a server
    has to take into consideration.

    PR:     253576
    Reviewed By:    tuexen, #transport
    MFC after:      3 days
    Sponsored by:   NetApp, Inc.
    Differential Revision: https://reviews.freebsd.org/D28652

    (cherry picked from commit 2593f858d7d078efa85f78f20b6bfa0931cc1dc5)

 sys/netinet/tcp_input.c    | 12 ++++++++----
 sys/netinet/tcp_syncache.c |  3 ++-
 2 files changed, 10 insertions(+), 5 deletions(-)