Bug 253586
| Summary: | [PATCH] databases/oracle8-client: unbreak for 13+ | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Konstantin Stroykovskiy <bonkor> | ||||||
| Component: | Individual Port(s) | Assignee: | Eugene Grosbein <eugen> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | eugen | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Base system "objcopy" is the "elfcopy" utility from elftoolchain for supported versions of FreeBSD (11+). It really has working --redefine-syms flag despite its manual pages does not document it. Have you really tested your patch and with which FreeBSD version? The change of NO_WERROR to MK_WERROR breaks build for both FreeBSD 11.4 and FreeBSD 12.2. Created attachment 222547 [details]
fix build for 13+
Dear maintainer, please test and approve alternative patch using system objcopy and not breaking build for other stable branches. Comment on attachment 222547 [details]
fix build for 13+
Port with this patch is working. Tested on 14.0 and 12.2.
A commit references this bug: Author: eugen Date: Fri Feb 19 07:25:33 UTC 2021 New revision: 566032 URL: https://svnweb.freebsd.org/changeset/ports/566032 Log: databases/oracle8-client: unbreak build for FreeBSD 13+ PR: 253586 Approved by: Konstantin Stroykovskiy (maintainer) Changes: head/databases/oracle8-client/files/patch-freebsd-Makefile head/databases/oracle8-client/files/patch-freebsd-redefine-syms.sh Fixed, thank you for the report! |
Created attachment 222527 [details] Patch needed to build the port Base system objcopy does not have the necessary functionality.