Bug 253588

Summary: java/openjdk8: replace ECHO with ECHO_CMD in Makefile
Product: Ports & Packages Reporter: Michael Muenz <m.muenz>
Component: Individual Port(s)Assignee: Jung-uk Kim <jkim>
Status: Closed FIXED    
Severity: Affects Only Me CC: franco, jkim
Priority: --- Flags: bugzilla: maintainer-feedback? (java)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
ECHO_CMD patch none

Description Michael Muenz 2021-02-17 14:50:41 UTC 
Created attachment 222528 [details]
ECHO_CMD patch

Hi,

when building via ports (not poudriere) it breaks building at dependency devel/sbt since it doesn't know where java is.

Replacing the simple ECHO with the standard ECHO_CMD fixes it.

Best,
Michael
Comment 1 Franco Fichtner 2021-02-17 14:53:29 UTC 
The problem actually is that when using "make -s" ECHO builtin is cleared and the vital port parts are not added... ECHO should not be used in Makefiles unless it is a verbose message.


Cheers,
Franco
Comment 2 Jung-uk Kim freebsd_committer freebsd_triage 2021-02-19 07:57:22 UTC 
I'll take it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-02-19 08:02:55 UTC 
A commit references this bug:

Author: jkim
Date: Fri Feb 19 08:02:02 UTC 2021
New revision: 566035
URL: https://svnweb.freebsd.org/changeset/ports/566035

Log:
  Replace ${ECHO} with ${ECHO_CMD}.

  ${ECHO} may be no-op when "make -s" is used.

  PR:		253588

Changes:
  head/java/openjdk8/Makefile
Comment 4 Jung-uk Kim freebsd_committer freebsd_triage 2021-02-19 08:06:13 UTC 
Committed, thanks!