Bug 253745
| Summary: | deskutils/coolreader: fix build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Olga Smirnova <mistresssilvara> | ||||||
| Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | fernape | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
(In reply to Olga Smirnova from comment #0) For which FreeBSD version does this patch fix the build? For all of them. There are some plist issues: ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: @dir share/cr3/hyph/obsolete ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Those are bogus. Is 'check-plist' mandatory for building a package successfully? Created attachment 222734 [details]
pkg-plist
If it is mandatory, here's the patch for the plist.
(In reply to Olga Smirnova from comment #5) The port installed files which were not registered in the pkg-plist, and hence the error. The builders use poudriere to build packages, so the package as it was before the pkg-plist patch, would not build either. As a rule, it is a very good idea to use poudriere to test the port (https://docs.freebsd.org/en/books/porters-handbook/#testing). Other tools like portlint and portclippy are in general good too (at least to my taste). Thanks for the patches! Committed, Thanks! A commit references this bug: Author: fernape Date: Tue Feb 23 07:13:57 UTC 2021 New revision: 566378 URL: https://svnweb.freebsd.org/changeset/ports/566378 Log: deskutils/coolreader: Unbreak build PR: 253745 Submitted by: mistresssilvara@hotmail.com (maintainer) Changes: head/deskutils/coolreader/Makefile head/deskutils/coolreader/pkg-plist |
Created attachment 222702 [details] Makefile patch Please commit the fix for the Coolreader build.