Bug 253773

Summary: comms/hcidump: unbreak it on 13-BETA1+ (1300133+)
Product: Ports & Packages Reporter: Michael Zhilin <mizhka>
Component: Individual Port(s)Assignee: Michael Zhilin <mizhka>
Status: Open ---    
Severity: Affects Only Me CC: fernape, lwhsu
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
SVN diff none

Description Michael Zhilin freebsd_committer freebsd_triage 2021-02-22 22:49:08 UTC 
Created attachment 222731 [details]
SVN diff

Hi,

Due to change of Mk option WERROR (https://reviews.freebsd.org/D27601) hcidump build is broken on worlds older than 1300133. 

This patch fixes build and change ownership from ports@ to mizhka@. Testport is done for 12.2 and 13.0-BETA1. 

Thanks!
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2021-02-25 06:48:42 UTC 
^Triage: [tags] in issue Titles are deprecated.

^Triage: Simplifying title

Q/A:  Makefile: [26]: whitespace before end of line.
 /tmp/253773/comms/hcidump/files/patch-hcidump-Makefile: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/253773/comms/hcidump/files/patch-parser-rfcomm.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
 /tmp/253773/comms/hcidump/files/patch-parser.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.

Q/A: Variables out of place:

# USES block
USES    

# CFLAGS/CXXFLAGS/LDFLAGS block
+CFLAGS                                    
                                                              
# WRKSRC block                                                                                                               
+INSTALL_WRKSRC
WRKSRC
-INSTALL_WRKSRC

-CFLAGS


^Triage: Please confirm this change passes QA (portlint, poudriere at least).
--
https://www.freebsd.org/doc/en/books/porters-handbook/testing.html


Thanks!