Bug 253776

Summary: multimedia/rtmpdump: fix build without optimizations
Product: Ports & Packages Reporter: Michael Zhilin <mizhka>
Component: Individual Port(s)Assignee: Hiroki Sato <hrs>
Status: Open ---    
Severity: Affects Some People CC: grahamperrin, jamie
Priority: --- Keywords: buildisok
Version: LatestFlags: bugzilla: maintainer-feedback? (hrs)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
SVN diff none

Description Michael Zhilin freebsd_committer freebsd_triage 2021-02-22 23:36:39 UTC
Created attachment 222733 [details]
SVN diff

Hi,

Build of multimedia/rtmpdump may fail in case of no optimization. For instance, if make.conf contains "WITH_DEBUG=yes" and "DEBUG_FLAGS=-g". 
The error message is following:

--- rtmpdump ---
ld: error: undefined symbol: CleanupSockets
>>> referenced by rtmpdump.c:1410
>>>               rtmpdump.o:(main)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [rtmpdump] Error code 1

The reason is incorrect definition of inline function CleanupSockets. The suggested patch adds "static" in definition of function and fixes problem. 

Testport is done on default and "debug" environment, on 12.2 and 13.0-BETA1.

Thanks!
Comment 1 Automation User 2021-03-09 00:12:26 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/267328462
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2022-10-17 12:39:52 UTC
Keyword: 

    patch
or  patch-ready

– in lieu of summary line prefix: 

    [patch]

* bulk change for the keyword
* summary lines may be edited manually (not in bulk). 

Keyword descriptions and search interface: 

    <https://bugs.freebsd.org/bugzilla/describekeywords.cgi>
Comment 3 Jamie Landeg-Jones 2023-11-06 14:04:06 UTC
(In reply to Michael Zhilin from comment #0)

Thanks. That worked!

Its just a shame that almost 3 years after you provided the fix, I had to find it in this unactioned report via a google search.