Bug 253782
| Summary: | New port: www/py-adblock Brave's adblock library in Python | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Jimerson <vendion> | ||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | nimaje+fbz, pi | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Why not using dns/public_suffix_list instead of maintaining a public suffix list in this port? Using dns/public_suffix_list would also mean this port agrees with other ports about public suffixes To better support WITH_DEBUG you should avoid stripping when WITH_DEBUG is set (${STRIP_CMD} already does that, so the only place I see that would need to change is do-build)
Maybe use ${WITH_DEBUG:D:U--strip} instead of --strip there (as suggested by make(1) for values that are only needed when a variable is undefined)
Thanks for the feedback! > Why not using dns/public_suffix_list instead of maintaining a public suffix list in this port? Using dns/public_suffix_list would also mean this port agrees with other ports about public suffixes I was not aware that dns/public_suffix_list existed, that is certainly better than having to patch in my own list. > Maybe use ${WITH_DEBUG:D:U--strip} instead of --strip there (as suggested by make(1) for values that are only needed when a variable is undefined) Good point, I'll add that to my do-build target, so those wont get stripped if WITH_DEBUG is set for the port. Created attachment 222780 [details]
Add port www/py-adblock, use dns/public_suffix_list, and allow debug builds
Replaced the patched in public suffix list with dns/public_suffix_list, and allow for debug builds.
Committed, thanks! A commit references this bug: Author: pi Date: Wed Mar 3 11:29:51 UTC 2021 New revision: 567071 URL: https://svnweb.freebsd.org/changeset/ports/567071 Log: New port: www/py-adblock Python wrapper for Brave's adblocking library, which is written in Rust. WWW: https://pypi.org/project/adblock/ PR: 253782 Submitted by: Adam Jimerson <vendion@gmail.com> Reviewed by: nimaje+fbz@bureaucracy.de Changes: head/www/Makefile head/www/py-adblock/ head/www/py-adblock/Makefile head/www/py-adblock/distinfo head/www/py-adblock/pkg-descr |
Created attachment 222739 [details] New port www/py-adblock This add a new port py-adblock with is a python wrapper around Brave's adblock library for use with www/qutebrowser (and any other application that may make use of this library).