Bug 253906

Summary: net/py-wsdd: uppercase LOGIN provision in BEFORE line in rc script
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: In Progress ---    
Severity: Affects Some People CC: hiroo.ono+freebsd
Priority: --- Flags: hiroo.ono+freebsd: maintainer-feedback+
dim: merge-quarterly+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Uppercase LOGIN provision in BEFORE: line none

Description Dimitry Andric freebsd_committer 2021-02-28 12:35:53 UTC
Created attachment 222872 [details]
Uppercase LOGIN provision in BEFORE: line

While experimenting with the new parallel rc loading on recent -CURRENT, I noticed a complaint from rcorder(8) about the wsdd rc script:

% rcorder /etc/rc.d/* /usr/local/etc/rc.d/*
rcorder: file `/usr/local/etc/rc.d/wsdd' is before unknown provision `login'
rcorder: file `/usr/local/etc/rc.d/saslauthd' is before unknown provision `imap'

In the "# BEFORE: login" line, the provision should be uppercased instead, e.g. "LOGIN". This makes the rcorder complaint go away.
Comment 1 Hiroo Ono 2021-02-28 12:49:38 UTC
Thank you for the patch.
Comment 2 commit-hook freebsd_committer 2021-02-28 13:02:22 UTC
A commit references this bug:

Author: dim
Date: Sun Feb 28 13:02:15 UTC 2021
New revision: 566760
URL: https://svnweb.freebsd.org/changeset/ports/566760

Log:
  net/py-wsdd: uppercase LOGIN provision in BEFORE line in rc script

  Avoid complaints from rcorder(8) about "unknown provision `login'". This
  was because the provision 'login' should be uppercased instead.

  Approved by:	hiroo.ono+freebsd@gmail.com (maintainer)
  PR:		253906
  MFH:		2021Q1

Changes:
  head/net/py-wsdd/Makefile
  head/net/py-wsdd/files/patch-etc_rc.d_wsdd
Comment 3 Dimitry Andric freebsd_committer 2021-02-28 13:09:13 UTC
Keeping this open until I get approval to merge into 2021Q1.