Bug 253930

Summary:	devel/lua-sysctl: fix module loading on lua 5.3+
Product:	Ports & Packages	Reporter:	Oleksii Samorukov <samm>
Component:	Individual Port(s)	Assignee:	freebsd-ports-bugs (Nobody) <ports-bugs>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	uzsolt
Priority:	---	Flags:	uzsolt: maintainer-feedback+
Version:	Latest
Hardware:	Any
OS:	Any

Description Oleksii Samorukov freebsd_committer

2021-03-01 07:19:12 UTC

I found that devel/lua-sysctl is broken on lua 5.3+.

Reason is usage of `lua_pushunsigned` which was removed later, it actually prints warning about it during compilation and triggers error (unresolved syntax) on load.

Comment 1 Oleksii Samorukov freebsd_committer

2021-03-01 07:22:49 UTC

Fix is available at https://reviews.freebsd.org/file/data/gxfrmopl44mjywxwjmd4/PHID-FILE-3ei27wlsg7ug6gcszzqk/D28992.diff

I also sent it to the upstream: https://github.com/kaworu/lua-sysctl/pull/8

Comment 2 Oleksii Samorukov freebsd_committer

2021-03-01 07:23:23 UTC

uzsolt@uzsolt.hu please approve changes.

Comment 3 commit-hook freebsd_committer

2021-03-01 07:58:24 UTC

A commit references this bug:

Author: samm
Date: Mon Mar  1 07:57:51 UTC 2021
New revision: 566833
URL: https://svnweb.freebsd.org/changeset/ports/566833

Log:
  devel/lua-sysctl: fix module loading on lua 5.3+

  PR:		253930
  Approved by:	uzsolt@uzsolt.hu (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D28992

Changes:
  head/devel/lua-sysctl/Makefile
  head/devel/lua-sysctl/files/
  head/devel/lua-sysctl/files/patch-src_lua__sysctl.c