Bug 253945

Summary: devel/upnp: Update to 1.14.2, take maintainership
Product: Ports & Packages Reporter: Dries Michiels <driesm>
Component: Individual Port(s)Assignee: Neel Chauhan <nc>
Status: Closed FIXED    
Severity: Affects Only Me CC: nc
Priority: --- Keywords: buildisok
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
upnp.diff
none
upnp.diff none

Description Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:43:33 UTC
Poudriere testport looks good. Its possible some ports need a portrevision bump given the shared lib has been bumped in this revision. I ran the script under Tol
ols/script/search_lib_depends_and_bump.sh but didn't find any port so should be OK.
Comment 1 Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:44:41 UTC
Created attachment 222909 [details]
upnp.diff

upnp.diff
Comment 2 Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:48:55 UTC
Created attachment 222910 [details]
upnp.diff

fold in some changes suggested by portclippy.
Comment 3 Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:52:49 UTC
I was lying about the dependent ports:

find . -name Makefile -exec grep -l "devel/upnp" {} \;
./net/gerbera/Makefile
./devel/upnp/Makefile
./multimedia/vlc/Makefile
./net-p2p/amule-devel/Makefile
./net-p2p/amule/Makefile
Comment 4 Automation User 2021-03-01 20:54:21 UTC
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/263698138
Comment 5 Dries Michiels freebsd_committer freebsd_triage 2021-03-01 20:54:57 UTC
Although after scanning each of the makefiles of those ports it seems that devel/upnp is not a standard dependency (always an option) => Do we still need to bump portrevision in that case?
Comment 6 Neel Chauhan freebsd_committer freebsd_triage 2021-03-01 21:34:37 UTC
Committed!
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-03-01 21:34:47 UTC
A commit references this bug:

Author: nc
Date: Mon Mar  1 21:34:28 UTC 2021
New revision: 566912
URL: https://svnweb.freebsd.org/changeset/ports/566912

Log:
  devel/upnp: Update to 1.14.2 and pass maintainership to submitter

  PR:		253945
  Submitted by:	Dries Michiels <driesm.michiels AT gmail DOT com>

Changes:
  head/devel/upnp/Makefile
  head/devel/upnp/distinfo
  head/devel/upnp/files/patch-upnp_src_genlib_net_http_httpreadwrite.c
  head/devel/upnp/pkg-plist