Bug 253978

Summary: net/coturn: rc script fixes
Product: Ports & Packages Reporter: Chris Rees <crees>
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed FIXED    
Severity: Affects Only Me CC: crees, yuri
Priority: --- Flags: bugzilla: maintainer-feedback? (yuri)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Fixes none

Description Chris Rees freebsd_committer 2021-03-03 11:01:08 UTC
Created attachment 222938 [details]
Fixes

Currently the pidfile doesn't match the rc script, fetch from config file.

The user should not be able to override the -o flag as this will hang startup, so move to command_args.

${name}_flags is included in command_args by rc.subr anyway, so remove that too.

Add description.

Pet rclint.

Integrate into ports Makefile correctly.
Comment 1 Chris Rees freebsd_committer 2021-03-03 11:02:00 UTC
Oops, really sorry, wrong assignee as I put the wrong port origin...
Comment 2 Yuri Victorovich freebsd_committer 2021-03-03 19:27:54 UTC
Committed, thanks!
Comment 3 commit-hook freebsd_committer 2021-03-03 19:28:39 UTC
A commit references this bug:

Author: yuri
Date: Wed Mar  3 19:27:41 UTC 2021
New revision: 567256
URL: https://svnweb.freebsd.org/changeset/ports/567256

Log:
  net/coturn: rc script fixes

  * Fetch pidfile from config file
  * Integrate into ports Makefile correctly
  * Pet rclint

  PR:		253978
  Submitted by:	crees

Changes:
  head/net/coturn/Makefile
  head/net/coturn/files/turnserver-service.in
  head/net/coturn/files/turnserver.in
  head/net/coturn/pkg-plist