Bug 253997

Summary:

Installer of 20210225 snapshot works with monochrome mode

Product:

Base System

Reporter:

Yasuhiro Kimura <yasu>

Component:

bin

Assignee:

freebsd-bugs (Nobody) <bugs>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

bapt, pi, unitrunker

Priority:

---

Keywords:

needs-qa, regression

Version:

CURRENT

Flags:

koobs: maintainer-feedback? (bapt)

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Snapshot image of console	none

Description Yasuhiro Kimura freebsd_committer

2021-03-03 21:08:02 UTC

Created attachment 222954 [details]
Snapshot image of console

I created VirtualBox VM for FreeBSD 64bit on Windows host and tried to make clean install of 14-CURRENT with iso image of 20210225 snapshot (FreeBSD-14.0-CURRENT-amd64-20210225-bf667f282a7-256946-disc1.iso). Then installer worked with monochrome mode. Attached file is the screen shot of console. If I start `bsdinstall` after installation is completed, it works with normal color mode. So the source of the problem seems not installer but console setting. Moreover I tested same iso image with real H/W of Windows host and the problem also
happened. So it isn't specific to VritualBox.

The problem doesn't happen with 20210218 snapshot. So I bisected between them and found it happens with following commit or later.

----------------------------------------------------------------------
commit 77e1ccbee3ed6c837929e4e232fd07f95bfc8294
Author:     Rick Parrish <unitrunker@gmail.com>
AuthorDate: Sun Feb 7 07:15:21 2021 +0100
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: Tue Feb 23 11:16:53 2021 +0100

    rc: implement parallel boot
    
    take advantage of the rcorder -p argument to implement parallel
    booting in rc.
    
    According to the author non scientific tests:
    on a Core 2 Duo with spinning disk:
    
    | Services enabled | before | after | saving |
    | 0                | 8s     | 8s    | 0      |
    | 1                | 13s    | 13s   | 0      |
    | 2                | 17s    | 13s   | 5      |
    | 3                | 23s    | 13s   | 10     |
    | 4                | 28s    | 13s   | 15     |
    | 5                | 33s    | 13s   | 20     |
    
    PR:             249192
    MFC after:      3 weeks

----------------------------------------------------------------------

There are some commits that fix issues related to it. So I made release build with aff9b9ee894 of main and tried created iso mage. But the problem still happens.

Cc-ing author and committer of above one.

Comment 1 Yasuhiro Kimura freebsd_committer

2021-03-04 00:05:56 UTC

I reverted following 5 commits from aff9b9ee89 of main and made release build.

763db589328 rc: save and restore $IFS
f1ab799927c rc: fix rc script parsing
6e822e99570 rc: fix parse of $local_startup
d27999e5139 Create dhclient pid directory if it doesn't exist
77e1ccbee3e rc: implement parallel boot

Then iso image works with normal color mode.

Comment 2 Yasuhiro Kimura freebsd_committer

2021-03-11 18:44:44 UTC

(In reply to Yasuhiro Kimura from comment #1)

These commits are reverted with f61831d2e8b of main. And I confirmed 20210311 snapshot of 14-CURRENT works fine.