Bug 254035

Summary:

x11/alacritty: support backend options

Product:

Ports & Packages

Reporter:

Ghost <2khramtsov>

Component:

Individual Port(s)

Assignee:

Mikael Urankar <mikael>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

2khramtsov

Priority:

---

Keywords:

patch

Version:

Latest

Flags:

bugzilla: maintainer-feedback? (mikael)

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
patch	none

Description Ghost 2021-03-05 14:35:15 UTC

Created attachment 223001 [details]
patch

Upstream supports backend selection: https://github.com/alacritty/alacritty/issues/3340

An obvious way to support backend selection is to only add CARGO_FEATURES to the port, but it would fail due to: https://github.com/rust-lang/cargo/issues/7727

One OS that supports disabling backends (e.g. Gentoo) does this by applying cargo options not to the root, but to the alacritty subdir: https://gitweb.gentoo.org/repo/gentoo.git/tree/x11-terms/alacritty/alacritty-9999.ebuild

Do the same and add backend options. This is needed for {Wayland,X11}-only builds.

portlint -A && poudriere testport: OK.

Comment 1 commit-hook freebsd_committer

2021-03-12 11:38:14 UTC

A commit references this bug:

Author: mikael
Date: Fri Mar 12 11:38:07 UTC 2021
New revision: 568171
URL: https://svnweb.freebsd.org/changeset/ports/568171

Log:
  x11/alacritty: Add video backend option

  PR:		254035
  Submitted by:	Evgeniy Khramtsov

Changes:
  head/x11/alacritty/Makefile

Comment 2 Mikael Urankar freebsd_committer

2021-03-12 11:38:36 UTC

Thanks!

Comment 3 Ghost 2021-03-12 13:51:41 UTC

Ping. You committed 'OPTIONS_DEFAULT= WAYLAND' instead of 'OPTIONS_DEFAULT= WAYLAND X11' which was in the patch. This breaks X11 support for package users (see: https://www.freshports.org/x11/alacritty/). Please fix this before pkg cluster does a rebuild, thanks.

Comment 4 Mikael Urankar freebsd_committer

2021-03-12 13:56:21 UTC

(In reply to Evgeniy Khramtsov from comment #3)
sorry, fixed in ports r568177