Bug 254131
| Summary: | www/qutebrowser: Add run time dependency on www/py-adblock for AMD64 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Jimerson <vendion> | ||||||
| Component: | Individual Port(s) | Assignee: | Roman Bogorodskiy <novel> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | fernape, nimaje+fbz, novel | ||||||
| Priority: | --- | Flags: | fernape:
maintainer-feedback?
(novel) |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
As it only adds an optional feature and ports/packages don't support suggested packages, this should be an OPTION, like youtube-dl is for mpv (In reply to nimaje+fbz from comment #1) Agreed, it won't hurt to make it an OPTION (enabled by default though). I'm okay with making this optional and enabled by defualt for AMD64 builds. It might take a few days for poudirere's testport to run on my build box. Created attachment 223205 [details]
Patch v2 to add py-adblock as RUN_DEPENS
This patch adds py-adblock as an OPTION for AMD64 builds.
Also after talking with the maintainer this patch makes a few small changes suggested by portclippy.
A commit references this bug: Author: novel Date: Sat Mar 13 01:33:25 UTC 2021 New revision: 568225 URL: https://svnweb.freebsd.org/changeset/ports/568225 Log: www/qutebrowser: add adblock support - Introduce ADBLOCK option that adds adblock support via www/py-adblock. As py-adblock is currently available only for amd64, limit the option to amd64 too, - Reorder some Makefile variables based on portclippy suggestions. PR: 254131 Submitted by: Adam Jimerson Changes: head/www/qutebrowser/Makefile Committed, thanks! |
Created attachment 223092 [details] Patch to add new RUN_DEPENDS This patch adds www/py-adblock as a runtime dependency if Qutebrowser is being built for AMD64.