Summary: | net/mosquitto 2.0.8 service fails to start | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jürgen Weber <weberbug> | ||||
Component: | Individual Port(s) | Assignee: | Craig Leres <leres> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | brd, j.kelly.hays, joe, leres, pixel, swills | ||||
Priority: | --- | Flags: | joe:
maintainer-feedback+
|
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Jürgen Weber
2021-03-13 11:52:25 UTC
Created attachment 223245 [details]
patch
Update the rc script.
Using grep to find the pidfile in the config file breaks if there is a comment in the config file that references the pidfile. This is why we typically lean towards not calling grep or trying to parse config files, but instead setting the pidfile to the default value in the rc script and having the user change it via rc.conf instead if it's a non-default value. I think it would be better to have: pidfile=${mosquitto_pidfile:-"/var/run/mosquitto.pid"} > Using grep to find the pidfile in the config file breaks ..
Or if you keep the original line commented out like I did 8-)
Will the package receive an update in order to solve this issue? @swills, would you be ok with something like this? pidfile=$(egrep ^pid_file ${mosquitto_config} | awk '{print($2)}') pidfile=${pidfile:=/var/run/mosquitto.pid} A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=baa26eb67c4d0d6406a190dec9214520a53c02e1 commit baa26eb67c4d0d6406a190dec9214520a53c02e1 Author: Brad Davis <brd@FreeBSD.org> AuthorDate: 2021-08-08 16:55:44 +0000 Commit: Brad Davis <brd@FreeBSD.org> CommitDate: 2021-08-08 16:55:44 +0000 net/mosquitto: Fix startup pidfile issue PR: 254254 Reviewed by: swills Approved by: joe@thrallingpenguin.com (maintainer, earlier version) net/mosquitto/Makefile | 1 + net/mosquitto/files/mosquitto.in | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) |