Bug 25435

Summary: ps -j asks for "sess" keyword, no longer defined
Product: Base System Reporter: Robert Watson <rwatson>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 5.0-CURRENT   
Hardware: Any   
OS: Any   

Description Robert Watson freebsd_committer freebsd_triage 2001-02-27 22:40:01 UTC 
Just upgraded to recent current (this morning), and found that ps with the
-j parameter gives a warning about the "sess" (session leader) keyword
being undefined:

Fix: 

No clear.  In any case, the "-j" arguments were not updated for whatever
removal of session leader from the list of valid fields when that occurred.
How-To-Repeat: 
sproing:~> ps ajx
ps: sess: keyword not found
USER      PID  PPID  PGID JOBC STAT  TT       TIME COMMAND
root        0     0     0    0 DWLs  ??    0:00.00  (swapper)
root        1     0     1    0 DWLs  ??    0:00.01 /sbin/init -d
...
Comment 1 dima 2001-02-28 04:40:23 UTC 
> >Number:         25435
> >Category:       bin
> >Synopsis:       ps -j asks for "sess" keyword, no longer defined
> 
> No clear.  In any case, the "-j" arguments were not updated for whatever
> removal of session leader from the list of valid fields when that occurred.

Indeed, mckusick didn't update the -j arguments or the manual page
when he introduced kproc_info.  The attached patch removes all
references to keywords removed by that commit from the source and
manual page.

					Dima Dorfman
					dima@unixfreak.org


Index: ps.1
===================================================================
RCS file: /st/src/FreeBSD/src/bin/ps/ps.1,v
retrieving revision 1.30
diff -u -r1.30 ps.1
--- ps.1	2001/02/01 16:24:50	1.30
+++ ps.1	2001/02/28 04:36:29
@@ -99,7 +99,7 @@
 header per page of information.
 .It Fl j
 Print information associated with the following keywords:
-user, pid, ppid, pgid, sess, jobc, state, tt, time and command.
+user, pid, ppid, pgid, jobc, state, tt, time and command.
 .It Fl L
 List the set of available keywords.
 .It Fl l
@@ -367,8 +367,6 @@
 job control count
 .It ktrace
 tracing flags
-.It ktracep
-tracing vnode
 .It lim
 memoryuse limit
 .It logname
@@ -400,8 +398,6 @@
 wait channel (as an address)
 .It oublk
 total blocks written (alias oublock)
-.It p_ru
-resource usage (valid only for zombie)
 .It paddr
 swap address
 .It pagein
@@ -427,8 +423,6 @@
 reverse link on run queue, or 0
 .It rss
 resident set size
-.It rsz
-resident set size + (text size / text use count) (alias rssize)
 .It rtprio
 realtime priority (101 = not a realtime process)
 .It ruid
@@ -436,8 +430,6 @@
 .Tn ID
 .It ruser
 user name (from ruid)
-.It sess
-session pointer
 .It sig
 pending signals (alias pending)
 .It sigcatch
Index: ps.c
===================================================================
RCS file: /st/src/FreeBSD/src/bin/ps/ps.c,v
retrieving revision 1.34
diff -u -r1.34 ps.c
--- ps.c	2001/01/24 12:59:50	1.34
+++ ps.c	2001/02/28 04:36:29
@@ -104,7 +104,7 @@
 static uid_t	*getuids(const char *, int *);
 
 char dfmt[] = "pid tt state time command";
-char jfmt[] = "user pid ppid pgid sess jobc state tt time command";
+char jfmt[] = "user pid ppid pgid jobc state tt time command";
 char lfmt[] = "uid pid ppid cpu pri nice vsz rss wchan state tt time command";
 char   o1[] = "pid";
 char   o2[] = "tt state time command";
Comment 2 dima 2001-02-28 05:37:38 UTC 
>  Indeed, mckusick didn't update the -j arguments or the manual page
>  when he introduced kproc_info.  The attached patch removes all

This should be kinfo_proc, of course.

					Dima Dorfman
					dima@unixfreak.org
Comment 3 dd freebsd_committer freebsd_triage 2001-04-07 04:18:26 UTC 
State Changed
From-To: open->closed

Fixed by brian in rev. 1.37 of bin/ps/ps.c (about time, too, 
considering I sent a patch for this almost one and a half months ago).