Bug 254568

Summary: games/0ad Perl Dependendcy
Product: Ports & Packages Reporter: Darrin Smith <beldin>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Some People CC: beldin
Priority: --- Flags: bugzilla: maintainer-feedback? (madpilot)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to add perl5 dependency
none
Failure Log
none
Copy of options from poudriere config none

Description Darrin Smith 2021-03-26 05:13:19 UTC
Created attachment 223595 [details]
Patch to add perl5 dependency

When building in a clean environment (such as under poudriere) perl is not installed as a dependency (requierd for spidermonkey component).

Attached patch simply adds perl5 dependency which solves the issue.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2021-03-26 09:22:41 UTC
Hi,

All my commits are tested in poudriere multiple times, and I'm well aware how poudriere clean environment works.

In my tests no perl5 dependency has ever been missing.

Can you please provide a failure log so I can check it?

Maybe you are using custom options for some other 0ad dependency that makes that one not install perl and 0ad then misses it.

In such a case you are correct in asking to add a perl dependency to 0ad, but before blindly doing that I would like to really understand why it is needed.

So first question is, are you using any customized option or port in you builds?

And again if you can provide the full failing log for 0ad.
Comment 2 Darrin Smith 2021-03-26 11:07:10 UTC
Created attachment 223608 [details]
Failure Log

Failure log attached, trimmed out most of the compiling code since the file would have blown out to 2.2M and attachment limit is 1M.

Custom options are probably used on a number of dependency ports.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2021-03-26 11:24:31 UTC
I think I have identified the difference. Just to make sure, could you post the options you use for x11-toolkits/wxgtk30 (output of "make showconfig" would be ideal). I guess you have disabled the webkit option.

Anyway you are correct and, since it is using it directly, at least a build time dependency is required. I'll test and commit the patch later.

BTW big log files can also be attached compressed with xz for example. Usually compression ratio for logs is quite good!
Comment 4 Darrin Smith 2021-03-26 12:01:57 UTC
Created attachment 223609 [details]
Copy of options from poudriere config

Here's

/usr/local/etc/poudriere.d/graphical-options/x11-toolkits_wxgtk30/options

from my poudriere config, and sure enough there's webkit being turned off.

Thanks for the tip on xz, I'll use it in future.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-03-26 19:04:08 UTC
A commit references this bug:

Author: madpilot
Date: Fri Mar 26 19:04:04 UTC 2021
New revision: 569266
URL: https://svnweb.freebsd.org/changeset/ports/569266

Log:
  Add explicit build dependency on perl.

  PR:		254568
  Submitted by:	beldin@beldin.org

Changes:
  head/games/0ad/Makefile
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2021-03-26 19:04:53 UTC
Committed. Thanks!