Bug 25458

Summary:	/etc/defaults/make.conf says to set PERL_THREADS = true but perl Makefile checks for "yes"
Product:	Base System	Reporter:	richard <richard>
Component:	gnu	Assignee:	Mark Murray <markm>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	4.2-STABLE
Hardware:	Any
OS:	Any

Description richard 2001-02-28 17:30:01 UTC

Looking through /etc/defaults/make.conf I tried making perl threaded. It didn't, upon examination the perl Makefile.inc in /usr/src/gnu/usr.bin/perl checks for PERL_THREADED=="yes" not "true" and thus the buildworld output showed usethreads=undef instead of usethreads=def.

Fix: 

Either /etc/defaults/make.conf or /usr/src/gnu/usr.bin/perl/Makefile.inc need to be updated.
How-To-Repeat: N/A

Comment 1 ru freebsd_committer

2001-02-28 17:40:16 UTC

State Changed
From-To: open->closed

Fixed in 4.2-STABLE, gnu/usr.bin/perl/Makefile.inc,v 1.12.2.2.

Comment 2 ru freebsd_committer

2001-02-28 17:40:16 UTC

Responsible Changed
From-To: freebsd-bugs->markm

To let the Mark know I MFC'ed the fix in his area.

Comment 3 Kris Kennaway 2001-03-12 00:30:45 UTC

On Wed, Feb 28, 2001 at 09:27:23AM -0800, richard@gohome.net wrote:

> Looking through /etc/defaults/make.conf I tried making perl
> threaded. It didn't, upon examination the perl Makefile.inc in
> /usr/src/gnu/usr.bin/perl checks for PERL_THREADED=="yes" not "true"
> and thus the buildworld output showed usethreads=undef instead of
> usethreads=def.

It shouldn't be testing for a value at all -- none of the other
feature-enable/disable variables in make.conf do, they're just tested
for existence.  IMO this should be done consistently.

Kris