Bug 254654
| Summary: | shells/fish: Fix build with OPTIONS_SET+=DEBUG | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kevin Zheng <kevinz5000> | ||||
| Component: | Individual Port(s) | Assignee: | Alan Somers <asomers> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | asomers:
maintainer-feedback+
|
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
LGTM! Thanks for the fix. Sorry I didn't notice it at first. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=77e8418d5acdbf09119536ca1586b28cdbdecc84 commit 77e8418d5acdbf09119536ca1586b28cdbdecc84 Author: Alan Somers <asomers@FreeBSD.org> AuthorDate: 2021-06-03 21:34:22 +0000 Commit: Alan Somers <asomers@FreeBSD.org> CommitDate: 2021-06-03 21:39:47 +0000 shells/fish: fix the build with the DEBUG option Approved by: dbaio (ports) Submitted by: Kevin Zheng <kevinz5000@gmail.com> PR: 254654 MFH: 2021Q2 shells/fish/pkg-plist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |
Created attachment 223703 [details] Patch When DEBUG is set in make.conf, CMake builds in debug mode. However, this does not cause the fish-releasenotes(1) man page to be installed as fish-debugnotes(1). Correct the entry in pkg-plist to fix the build in this case.