Bug 254674
| Summary: | games/minetest: update and improve makefile, remove patch | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | tigersharke | ||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||
| Status: | Closed Not Accepted | ||||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(amdmi3) |
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 223727 [details]
entire modified makefile referenced by diff
Should the git diff not be what is most useful, I am providing the Makefile which I fairly heavily modified. It has been run through portlint and portfmt which may account for some line juggling beyond my own specific changes.
- Sorry, I won't accept options to use bundled libs - bundling is evil, unsafe and should be avoided while possible. - Please exclude unnecessary noise such as whitespace and lists sorting or submit it as a separate patch - As far as I can see the only functional change here is option to not use glvnd. Is there any report of failure with default setup? If yes, does it affect other opengl ports? If that's the case it should probably be handled in a centralized way in gl.mk or cmake.mk, not each individual port. |
Created attachment 223726 [details] git diff output for games/minetest The attached git diff provides the changes proposed. A number of options are newly exposed, cmake mechanisms used to affect the changes to the build. Users have the choice whether to take advantage of system jsoncpp or gmp (as both have proper build cmake options), or to use those bundled. An radio button for graphics permits users to choose LEGACY or GLVND option for graphics support. The file patch-src_CMakeLists.txt seems unnecessary as it builds and installs fine without it.