Bug 254734

Summary: x11/keybinder-gtk3: add DOCS/EXAMPLES options
Product: Ports & Packages Reporter: John Hein <jcfyecrayz>
Component: Individual Port(s)Assignee: Rainer Hurling <rhurlin>
Status: Closed FIXED    
Severity: Affects Only Me CC: rhurlin
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
[patch] add DOCS/EXAMPLES
none
[patch] add DOCS/EXAMPLES v2
none
[patch] add DOCS/EXAMPLES v3 none

Description John Hein 2021-04-03 03:39:01 UTC
Created attachment 223781 [details]
[patch] add DOCS/EXAMPLES

Add DOCS & EXAMPLES options for x11/keybinder-gtk3.  The examples were never installed before and can be useful.  They are lightweight.

While here accommodate portlint warnings (line ordering).  Also get rid of unnecessary DISTNAME complication.  Bump PORTREVISION (EXAMPLES is on by default - that will change the package).

QA:
  portlint (ok)
  poudriere (ok, tested with all options combinations)
Comment 1 Rainer Hurling freebsd_committer freebsd_triage 2021-04-17 05:30:32 UTC
Created attachment 224175 [details]
[patch] add DOCS/EXAMPLES v2

Hi John,

I tried your patch on Poudriere and it builds and installs fine, as you mentioned before ;)

However, if I also build the dependent ports [1], there is a conflict in x11/guake:

pkg-static: keybinder-0.3.1_5 conflicts with keybinder-gtk3-0.3.2_1 
(installs files into the same place).  
Problematic file: /usr/local/share/examples/keybinder/Makefile

Obviously, guake needs both keybinder versions, gtk2 and gtk3, as run dependencies. I solved this conflict by also adding the version number to the keybinder directory under examples.


[1] audio/pragha, audio/xfce4-pulseaudio-plugin, deskutils/synapse, deskutils/xfce4-volumed-pulse, multimedia/peek, x11/guake, x11/terminator, x11/ulauncher

BTW: I reordered some Makefile vars again after recommendations from portclippy.


If you are fine with these changes, I would commit the patch v2 :)
Comment 2 Rainer Hurling freebsd_committer freebsd_triage 2021-04-17 07:49:16 UTC
Created attachment 224179 [details]
[patch] add DOCS/EXAMPLES v3

I just noticed that the docs are installed even if the DOCS option is disabled.

From the gtk2 version of the keybinder port I have borrowed the corresponding functionality, with which now actually no more docs are installed :)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-04-20 20:15:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2f3ebf0769a80a4492f800b3df9f3e2516bbe68f

commit 2f3ebf0769a80a4492f800b3df9f3e2516bbe68f
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2021-04-20 20:10:47 +0000
Commit:     Rainer Hurling <rhurlin@FreeBSD.org>
CommitDate: 2021-04-20 20:10:47 +0000

    x11/keybinder-gtk3: Add DOCS/EXAMPLES options

    - Make installation of docs and examples optional
    - Correct DISTVERSIONPREFIX
    - Needs USES=autoreconf to suppress docs install
    - Reorder some Makefile vars

    PR:             254734
    Submitted by:   John Hein <jcfyecrayz@liamekaens.com>

 x11/keybinder-gtk3/Makefile  | 26 ++++++++++++++++++++------
 x11/keybinder-gtk3/pkg-plist | 42 ++++++++++++++++++++++++++----------------
 2 files changed, 46 insertions(+), 22 deletions(-)
Comment 4 Rainer Hurling freebsd_committer freebsd_triage 2021-04-20 20:20:13 UTC
Committed, thanks :)