Bug 254747
| Summary: | [NEW PORT] devel/rgxg: Regular expression generator | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | alexander naumochkin <alexander.naumochkin> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Juraj Lutter <otis> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | diizzy, otis | ||||||||||||||
| Priority: | --- | Keywords: | feature | ||||||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(otis) koobs: maintainer-feedback? (diizzy) |
||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Hi Alexander, A few things that can be improved. :-) PORTVERSION --> DISTVERSION Porters Handbook - "Table 5.2. Package Naming Examples" 5.4.3. USE_GITHUB "If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file" In this case upstream provides one, https://github.com/rgxg/rgxg/releases/tag/v0.1.2 --> https://github.com/rgxg/rgxg/releases/download/v0.1.2/rgxg-0.1.2.tar.gz so please use that instead. Please define DOCS and possibly MANPAGES as port options Thanks for your contribution! Best regards, Daniel Created attachment 223810 [details]
devel/rgxg new port
updated Makefile for port
Hi Daniel, I've modified Makefile following your recomendations about *VERSION and MASTER_SITES, check it, please. But at the moment I'm not sure what to do with DOCS/MANPAGES without patching configure.ac, because docs/man-pages installation are not options with it. Do I have to make the patch or ask author for that? Sorry for my newbie questions, this is my first port :) Created attachment 223845 [details]
Patch for rgxg
Add pkgconf(ig) as dependency
Disable static library
Add DOCS option
I initially didn't look at upstream but as you said upstream doesn't have options for it. The ports framework does however let you do create these options as it can automatically ignore file(s) if you "bind" them to an option ("knob") (OPTIONS_SUB in Porters Handbook, PORTDOCS enables it by default and adds items automatically to plist) however there's no need to overengineer so I just made a DOCS option.
I should also mention that I learned a few new things thanks to jrm@ and mat@ by hacking on this. :-)
This version also passes Poudriere on 12.2-RELEASE
Best regards,
Daniel
Created attachment 223976 [details]
devel/rgxg new port
Corrected (and final I hope) version
Hi Daniel, thanks alot for your mentoring, I've attached new edition of .shar. Hope it is good enough to adopt. If everything is Ok, should I do something else with this "bug-report"? Best regards, alexander Created attachment 224227 [details]
Patch for rgxg v2
Remove "Created by" and deprecated SVN entry ( $FreeBSD$ )
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Hi Alexander, Can you please review "Patch for rgxg v2" I've done some style cleanup and COMMENT= follows ports framework style (no non standard capitals) This should be ready to commit Best regards, Daniel Created attachment 224391 [details]
devel/rgxg new port
style cleanup according to daniels advisory
Hi Daniel, hope this will become final version best, alexander Hi Alex, Sorry for the late reply but what did you change for the last patch compared to the one I submitted? (In reply to daniel.engberg.lists from comment #12) Hi Daniel, just as you said in comment #9 — some style cleanup. diff --git a/Makefile b/Makefile index 3641e6d..b975a4e 100644 --- a/Makefile +++ b/Makefile @@ -1,13 +1,10 @@ -# Created by: alexander naumochkin <alexander.naumochkin@gmail.com> -# $FreeBSD$ - PORTNAME= rgxg DISTVERSION= 0.1.2 CATEGORIES= devel MASTER_SITES= https://github.com/${PORTNAME}/${PORTNAME}/releases/download/v${DISTVERSION}/ MAINTAINER= alexander.naumochkin@gmail.com -COMMENT= ReGular eXpression Generator +COMMENT= Regular expression generator LICENSE= ZLIB LICENSE_FILE= ${WRKSRC}/COPYING Hi Daniel, is something wrong still? up! Sorry for the late reply! No, it should be fine now however you don't need to submit the patch in another format if its already attached. :-) Regards, Daniel ^Triage: What needs to happen to resolve this issue? A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4a6c4a258ae524df314a5a4cee64bfabf7275d99 commit 4a6c4a258ae524df314a5a4cee64bfabf7275d99 Author: alexander naumochkin <alexander.naumochkin@gmail.com> AuthorDate: 2021-09-03 06:47:52 +0000 Commit: Juraj Lutter <otis@FreeBSD.org> CommitDate: 2021-09-03 06:47:52 +0000 devel/rgxg: Add port: a ReGular eXpression Generator. rgxg (ReGular eXpression Generator) is a C library and a command-line tool to generate (extended) regular expressions. https://github.com/rgxg/rgxg PR: 254747 devel/rgxg/Makefile (new) | 28 ++++++++++++++++++++++++++++ devel/rgxg/distinfo (new) | 3 +++ devel/rgxg/pkg-descr (new) | 4 ++++ devel/rgxg/pkg-plist (new) | 17 +++++++++++++++++ 4 files changed, 52 insertions(+) It took time, but committed. Thanks! |
Created attachment 223790 [details] devel/rgxg new port extended regular expression generator especially useful for ip (v4 and v6) matching regexes