Summary: | dns/nsd: Update to 4.3.6 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jaap Akkerhuis <jaap> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Many People | CC: | diizzy, kbowling | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
URL: | https://nlnetlabs.nl/news/2021/Apr/06/nsd-4.3.6-released/ | ||||||
Attachments: |
|
Description
Jaap Akkerhuis
2021-04-07 11:03:03 UTC
Hi, I few things I spotted PORTVERSION --> DISTVERSION See "Table 5.2. Package Naming Examples" in Porters Handbook http://www.nlnetlabs.nl - redirects to https ftp.rhnet.is doesn't seem to resolve LIB_DEPENDS+= should be LIB_DEPENDS= CONFLICTS= can probably be removed by now? Best regards, Daniel A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b69bbb6794847ce677f8466ff2911a52958f1463 commit b69bbb6794847ce677f8466ff2911a52958f1463 Author: Kevin Bowling <kbowling@FreeBSD.org> AuthorDate: 2021-04-08 03:29:37 +0000 Commit: Kevin Bowling <kbowling@FreeBSD.org> CommitDate: 2021-04-08 03:29:37 +0000 dns/nsd: Update to 4.3.6 Changelog https://nlnetlabs.nl/news/2021/Apr/06/nsd-4.3.6-released/ PR: 254850 Reviewed by: daniel.engberg.lists@pyret.net Approved by: Jaap Akkerhuis <jaap@NLnetLabs.nl> (maintainer) dns/nsd/Makefile | 9 +++------ dns/nsd/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 9 deletions(-) Thanks to both of you for the patch and review. (In reply to daniel.engberg.lists from comment #1) Note it has always been using PORTVERSION as far as I know. This seems to be standard for (dns) ports. A quick scan shows 248 times PORTVERSION against 69 times for DISTVERSION. It if ftp.rhnet.is stopped working, it is fine with me. The LIB_DEPENDS += was on request since 2014 (See bug #186693). I would prefer to keep the CONFLICTS line. There is no direct need to remove it, and I don't want to speculate how many people are still running old cruft. (In reply to Jaap Akkerhuis from comment #4) We've never separated ports by category and for that matter ports framework do move forward like most software. :) This specific change is more than 2 years old and while there hasn't been a treewide sweep we should try to follow Porter's handbook as much as possible. First occurrence of LIB_DEPENDS shouldn't use += however following once should otherwise you'd be overriding the previous variable. As for conflicts, nsd3 was removed 5 years ago and nsd got bumped to 4.x in late 2013 so I think that's a reasonable change. The suggested changes matched the standards and directions of the ports tree. It's stylistic and should not impact future updates to the port. |