Bug 254922

Summary: security/john: Update to 1.9, fix build when OpenCL is installed
Product: Ports & Packages Reporter: Thierry Dussuet <thierry.dussuet>
Component: Individual Port(s)Assignee: Alexey Dokuchaev <danfe>
Status: Open ---    
Severity: Affects Only Me CC: lantw44
Priority: --- Flags: bugzilla: maintainer-feedback? (danfe)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Recursive diff for the version update
none
Non-recursive diff
none
Latest version with opencl, openmp, openmpi options none

Description Thierry Dussuet 2021-04-09 16:25:38 UTC
Created attachment 223949 [details]
Recursive diff for the version update

This patch would allow an update to version 1.9.0, and allows the port to build built even when OpenCL is installed.
On FreeBSD 12.2, version 1.9.0 builds with OpenCL support if enabled, but lacking the necessary hardware I could not fully test it.
On FreeBSD 13.0-CURRENT, there were build errors with OpenCL support enabled. Without OpenCL it was fine.
This should also solve bug report number #247229.
Comment 1 Thierry Dussuet 2021-04-09 16:27:23 UTC
Created attachment 223950 [details]
Non-recursive diff

This is the non-recursive diff. Basically the same as recursive, but the files/ directory is no longer necessary so this one is easier to read.
Comment 2 Thierry Dussuet 2021-04-12 16:35:32 UTC
Created attachment 224054 [details]
Latest version with opencl, openmp, openmpi options

Hi, played around a bit more with this during the weekend and got version 1.9 working with OpenCL, OpenMP and OpenMPI, with the latest changes from github, so added them as options. Hope this can be useful.
Portlint is complaining that the first line should have $FreeBSD$ as it is a comment, not sure how to handle this?
Comment 3 Alexey Dokuchaev freebsd_committer 2021-04-16 09:59:16 UTC
(In reply to Thierry Dussuet from comment #2)
> Portlint is complaining that the first line should have $FreeBSD$ as it is
> a comment, not sure how to handle this?
Just ignore this, it doesn't matter.