Bug 254952

Summary: databases/mariadb105-server: fails to build with COLUMNSTORE engine on
Product: Ports & Packages Reporter: Tommy P <tommyhp2>
Component: Individual Port(s)Assignee: Bernard Spil <brnrd>
Status: In Progress ---    
Severity: Affects Only Me CC: wolfgang
Priority: --- Flags: bugzilla: maintainer-feedback? (brnrd)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Build log from poudriere none

Description Tommy P 2021-04-10 17:01:27 UTC
Created attachment 223993 [details]
Build log from poudriere

MariaDB 10.5 server failed to build with COLUMNSTORE on:

make showconfig
===> The following configuration options are available for mariadb105-server-10.5.9:
     CONNECT_EXTRA=on: Enable ODBC and XML in CONNECT engine
     DOCS=off: Build and/or install documentation
     WSREP=on: Build wsrep clustering
====> Optional page compression
     LZ4=on: LZ4 compression support
     LZO=on: LZO compression support
     SNAPPY=on: Snappy compression library support
     ZSTD=on: Zstandard compression support (RocksDB only)
====> Optional MariaDB storage engines
     COLUMNSTORE=on: Columnar storage egine (BETA)
     INNOBASE=on: InnoDB default engine
     MROONGA=on: Mroonga Full Text Search engine
     OQGRAPH=on: Open Query Graph Computation engine
     ROCKSDB=on: RocksDB LSM engine
     S3=on: S3 storage engine (Alpha)
     SPHINX=on: SphinxSE engine
     SPIDER=on: Partitioning and XA-transactions engine
====> Optional Mroonga features
     ZMQ=on: ZeroMQ support
     MSGPACK=on: MsgPack support
====> GSSAPI Security API support: you have to select exactly one of them
     GSSAPI_BASE=off: GSSAPI support via base system (needs Kerberos)
     GSSAPI_HEIMDAL=off: GSSAPI support via security/heimdal
     GSSAPI_MIT=on: GSSAPI support via security/krb5
     GSSAPI_NONE=off: Disable GSSAPI support
===> Use 'make config' to modify these settings

If COLUMNSTORE is off, everything builds successfully.
-----------------------------------------------------
Line 2313 from submitted poudriere log:

storage/columnstore/columnstore/utils/rwlock/rwlock.cpp:66:14: error: no member named 'tr1' in namespace 'std'
typedef std::tr1::unordered_map<int, RWLockShmImpl*> LockMap_t;
        ~~~~~^
storage/columnstore/columnstore/utils/rwlock/rwlock.cpp:120:5: error: '(anonymous namespace)::LockMap_t' (aka 'int') is not a class, namespace, or enumeration
    LockMap_t::iterator iter;
    ^
storage/columnstore/columnstore/utils/rwlock/rwlock.cpp:120:16: error: use of class template 'iterator' requires template arguments
    LockMap_t::iterator iter;
               ^
/usr/include/c++/v1/iterator:627:29: note: template is declared here
struct _LIBCPP_TEMPLATE_VIS iterator
                            ^
storage/columnstore/columnstore/utils/rwlock/rwlock.cpp:125:22: error: member reference base type '(anonymous namespace)::LockMap_t' (aka 'int') is not a structure or union
    iter = lockMapPtr->find(key);
           ~~~~~~~~~~^ ~~~~
storage/columnstore/columnstore/utils/rwlock/rwlock.cpp:127:27: error: member reference base type '(anonymous namespace)::LockMap_t' (aka 'int') is not a structure or union
    if (iter == lockMapPtr->end())
                ~~~~~~~~~~^ ~~~
storage/columnstore/columnstore/utils/rwlock/rwlock.cpp:132:19: error: member reference base type '(anonymous namespace)::LockMap_t' (aka 'int') is not a structure or union
        lockMapPtr->insert(make_pair(key, ptr));
        ~~~~~~~~~~^ ~~~~~~
6 errors generated.
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2023-04-10 11:55:25 UTC
Did you report this upstream as well? Can you link the issue?
Comment 2 wolfgang 2023-06-28 10:23:20 UTC
The upstream issue is MCOL-4839 and is marked as closed / fixed since 2021-08-23
mariadb105-server builds for me on FreeBSD 12 and FreeBSD 13 with COLUMNSTORE enabled. I suggest to remove the COLUMNSTORE_BROKEN line from Makefile and close this bug.