Bug 254971

Summary: net/gitup: ignored paths aren't ignored
Product: Ports & Packages Reporter: Peter Jeremy <peterj>
Component: Individual Port(s)Assignee: Nuno Teixeira <eduardo>
Status: Closed FIXED    
Severity: Affects Only Me CC: chris
Priority: --- Flags: bugzilla: maintainer-feedback? (eduardo)
Version: Latest   
Hardware: Any   
OS: Any   
Description Flags
Patch to make gitup ignore paths marked ignore. none

Description Peter Jeremy freebsd_committer 2021-04-11 06:27:08 UTC
Created attachment 224009 [details]
Patch to make gitup ignore paths marked ignore.

gitup currently does a complete walk of the specified target directory, including any paths marked as "ignore".  In the case of (eg) ports, this means that the packages and distfiles directories will be unnecessarily scanned and hashed.

On my system that amounts to spending 4 hours hashing 100GB of data.

The attached patch skips ignored paths at all stages.
Comment 1 Nuno Teixeira freebsd_committer 2021-04-12 06:18:12 UTC
Hello Peter!

That seems a very interesting work to fix the problem you found in gitup.

I was thinking why not open an issue in gitup upstream about it or clone it and then try push changes so that this bug is fixed upstream?

What do you think?
Comment 2 Nuno Teixeira freebsd_committer 2021-04-26 03:52:55 UTC
Hello Peter,

This PR is at https://github.com/johnmehr/gitup/issues/64

Comment 3 Nuno Teixeira freebsd_committer 2021-04-26 04:03:50 UTC
Could you take a look?
Comment 4 Nuno Teixeira freebsd_committer 2021-04-26 04:29:16 UTC
Comment 5 Peter Jeremy freebsd_committer 2021-04-26 08:41:34 UTC
Thanks for raising the issue upstream.  I am happy to close this as superseded by https://github.com/johnmehr/gitup/issues/64
Comment 6 Nuno Teixeira freebsd_committer 2021-05-06 05:46:10 UTC
Thanks, let's wait for next release that includes this fix.