Bug 255025
| Summary: | textproc/py-chardet: Update to 4.0.0 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | takefu | ||||
| Component: | Individual Port(s) | Assignee: | Wen Heping <wen> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Only Me | CC: | python, swills, wen | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(python) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256219 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275631 |
||||||
| Attachments: |
|
||||||
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cbb8e36106080a07bcedff674c1ee411b70aef35 commit cbb8e36106080a07bcedff674c1ee411b70aef35 Author: Wen Heping <wen@FreeBSD.org> AuthorDate: 2021-06-01 10:11:21 +0000 Commit: Wen Heping <wen@FreeBSD.org> CommitDate: 2021-06-01 10:11:21 +0000 textproc/py-chardet: Update to 4.0.0 PR: 255025 Submitted by: takefu@airport.fm textproc/py-chardet/Makefile | 3 +-- textproc/py-chardet/distinfo | 6 +++--- textproc/py-chardet/files/patch-test.py (gone) | 16 ---------------- 3 files changed, 4 insertions(+), 21 deletions(-) ^Triage: Assign to committer that resolved @Wen At least one port (py-aiohttp)declares a version-spec for chardet <4.0 This update breaks that port and its dependents What testing was run for this change? https://github.com/freebsd/freebsd-ports/blob/main/www/py-aiohttp/Makefile#L17 (In reply to Kubilay Kocak from comment #2) Sorry the commit break www/py-aiohttp. Hope PR/256219 would be committed soon. if not, I would revert this commit. wen (In reply to Wen Heping from comment #3) Note that aiohttp may not be the only port impacted Re aiohttp though, given the fallout, if you can QA bug 256219 in short order, and I provided review in 256219#c4 you are free to land that change. That fixes that, however... If confirming no other ports are not affected cant be done in short order, I'd probably revert the change. (In reply to Kubilay Kocak from comment #4) I would check all the ports depends on py-chardet now. wen www/py-httpx013 require textproc/py-chardet<4, I would suggest create textproc/py-chardet3 to keep www/py-httpx013 build. How about it ? wen (In reply to Wen Heping from comment #6) Your call Wen. This seems to have broken biology/py-resdk too: https://lists.freebsd.org/archives/freebsd-pkg-fallout/2021-August/080466.html (In reply to Steve Wills from comment #8) I send a patch to yuri@ to unbreak it. wen Please close the following problems if they have been resolved. www/py-aiohttp www/py-httpx013 biology/py-resdk :-p www/py-aiohttp has been fixed in ports 101dc21632a03f33874b0c4226afeff710cf6ccf. www/py-httpx013 has been fixed in ports 355fc057d311fd9509653c34142aa26e5d00356e. biology/py-resdk has been fixed in ports bb97b107cebb25f350dab46cb07cef97609759be. |
Created attachment 224075 [details] py-chardet-4.0.0,1.patch