Bug 255149

Summary: security/doas: @DOAS_CONF@ not substituted in vidoas
Product: Ports & Packages Reporter: Jethro Nederhof <jethro>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Some People CC: jsmith
Priority: --- Flags: jsmith: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/slicer69/doas/releases/tag/6.3p5
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256447
Attachments:
Description Flags
patch to install vidoas.final as vidoas none

Description Jethro Nederhof 2021-04-17 11:51:30 UTC 
Created attachment 224185 [details]
patch to install vidoas.final as vidoas

The vidoas utility tries to edit a "./@DOAS_CONF@" file unless a specific config file is specified; this should instead try to edit the default config file /usr/local/etc/doas.conf

@DOAS_CONF@ is supposed to be replaced with $(DESTDIR)$(PREFIX)/etc/doas.conf as part of the all/install targets per: https://github.com/slicer69/doas/blob/be85cdabda861f63bd478d4113a238554d6512ef/Makefile#L100

In the port/pkg this only happens to the other *.final files, and the port installs vidoas instead of vidoas.final
Comment 1 Jesse Smith 2021-04-17 12:55:58 UTC 
Patch looks good to me. Let's do it.