Bug 255166
| Summary: | net/quiche: update to 0.8.1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Junho Choi <junho.choi> | ||||||
| Component: | Individual Port(s) | Assignee: | Rainer Hurling <rhurlin> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | rhurlin | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://github.com/cloudflare/quiche/releases/tag/0.8.1 | ||||||||
| Attachments: |
|
||||||||
Hi Junho Choi, Thanks for the patch. As the maintainer of the ports, would you please also set the 'maintainer approval' flag to '+' (in the attachments area, under Details for you patch...)? (In reply to Rainer Hurling from comment #1) Done! I didn't know that. Thanks! Created attachment 224221 [details]
patch with reordered Makefile vars
Your patch is tested now on Poudriere.
I reordered several Makefile vars, as suggested by portclippy. If you are ok with this reordering, I will commit that version. Please give a short feedback, thanks :)
(In reply to Rainer Hurling from comment #3) LGTM. Please go ahead. Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=72b4c9dd9b214e5c8785494ed92fc39568c15603 commit 72b4c9dd9b214e5c8785494ed92fc39568c15603 Author: Rainer Hurling <rhurlin@FreeBSD.org> AuthorDate: 2021-04-18 16:55:22 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2021-04-18 16:55:22 +0000 net/quiche: Update to 0.8.1 Changelog: https://github.com/cloudflare/quiche/releases/tag/0.8.1 PR: 255166 Submitted by: Junho Choi <junho.choi@gmail.com> (maintainer) net/quiche/Makefile | 145 +++++++++++++++++++++---------------- net/quiche/distinfo | 204 ++++++++++++++++++++++++++++++++-------------------- 2 files changed, 211 insertions(+), 138 deletions(-) Committed, thanks :) (In reply to Rainer Hurling from comment #6) Thanks, btw, why BUILD_DEPENDS was added? When I tested locally it was not required. (In reply to Junho Choi from comment #7) Oops, thank you for taking another close look. The Build_depends line is clearly wrong here and has probably crept in via copy and paste error. I have also worked on a gis port at the same time. Probably I can remove the line only in a few hours, because I am currently on the road. I am very sorry and thanks again! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=05f5aecccbfa7acbca75cc6efd727858d55aae2c commit 05f5aecccbfa7acbca75cc6efd727858d55aae2c Author: Rainer Hurling <rhurlin@FreeBSD.org> AuthorDate: 2021-04-19 06:51:47 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2021-04-19 16:42:50 +0000 net/quiche: Remove unneeded dependency Dependency archivers/lazperf crept in via copy and paste error. PR: 255166 Reported by: Junho Choi <junho.choi@gmail.com> (maintainer) net/quiche/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) I hope the port is ok now. Thanks again for the hint! |
Created attachment 224205 [details] port diff of quiche-0.8.1 Update to 0.6.0 -> 0.8.1.