Bug 25522
| Summary: | FORBIDDEN ports doesn't return error for dependencies | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | alex <alex> |
| Component: | Individual Port(s) | Assignee: | Port Management Team <portmgr> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-ports->asami Over to maintainer. Responsible Changed From-To: asami->portmgr Over to new maintainer. State Changed From-To: open->closed The problem was resolved in rev.1.410 of bsd.port.mk. Thank you for submission! |
lang/scheme48 is marked FORBIDDEN lang/slib depends on scheme48. root:/usr/ports/lang/slib $ make depends ===> slib-2c9 depends on executable: scheme48 - not found ===> Verifying install for scheme48 in /usr/ports/lang/scheme48 ===> scheme48-0.53 is forbidden: emails love notes to authors on install. ===> Returning to build of slib-2c9 ===> slib-2c9 depends on executable: scm - found ===> slib-2c9 depends on executable: unzip - found of course, install of slib fails: ===> Installing for slib-2c9 ===> Generating temporary packing list # moved here from author's makefile /usr/bin/touch -r /storage/ports/lang/slib/work/slib/slibcat /usr/local/lib/scheme48/slibcat touch: /usr/local/lib/scheme48/slibcat: No such file or directory *** Error code 1 Fix: I propose this or a similar patch: The result: root:/usr/ports/lang/slib $ make depends ===> slib-2c9 depends on executable: scheme48 - not found ===> Verifying install for scheme48 in /usr/ports/lang/scheme48 ===> scheme48-0.53 is forbidden: emails love notes to authors on install. *** Error code 1 Stop in /storage/ports/lang/scheme48. *** Error code 1 Stop in /storage/ports/lang/slib. *** Error code 1 Stop in /storage/ports/lang/slib. root:/usr/ports/lang/scheme48 $ make install ===> scheme48-0.53 is forbidden: emails love notes to authors on install. root:/usr/ports/lang/scheme48 $--Ko1AgLpNis7syO7tOI1Bebvl6oAApuQvo3BWc6oLvWnDKQ9p Content-Type: text/plain; name="file.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="file.diff" Index: /usr/ports/Mk/bsd.port.mk =================================================================== RCS file: /usr/home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.362 diff -u -r1.362 bsd.port.mk --- /usr/ports/Mk/bsd.port.mk 2001/02/17 00:46:26 1.362 +++ /usr/ports/Mk/bsd.port.mk 2001/03/04 14:39:14 @@ -1492,24 +1492,54 @@ .endif fetch: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif checksum: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif extract: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif patch: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif configure: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif all: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif build: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif install: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif reinstall: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif package: @${IGNORECMD} +.if defined(INSTALLS_DEPENDS) + @exit 1 +.endif .endif .endif @@ -2515,7 +2545,7 @@ if [ ! -d "$$dir" ]; then \ ${ECHO_MSG} " >> No directory for $$prog. Skipping.."; \ else \ - (cd $$dir; ${MAKE} $$target $$depends_args) ; \ + (cd $$dir; ${MAKE} -DINSTALLS_DEPENDS $$target $$depends_args) ; \ ${ECHO_MSG} "===> Returning to build of ${PKGNAME}"; \ fi; \ fi; \ How-To-Repeat: See above