Summary: | loader: Fix empty loader_menu_title | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Jose Luis Duran <jlduran> | ||||
Component: | misc | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | tsoome | ||||
Priority: | --- | ||||||
Version: | CURRENT | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=4ba91fa0736bb0672d475b6b56d9e7b06e78ff69 commit 4ba91fa0736bb0672d475b6b56d9e7b06e78ff69 Author: Toomas Soome <tsoome@FreeBSD.org> AuthorDate: 2021-04-21 11:42:10 +0000 Commit: Toomas Soome <tsoome@FreeBSD.org> CommitDate: 2021-04-21 11:50:23 +0000 loader: do not output empty menu title As we output spaces around the menu title, we should also check, if the title is actually empty string. PR: 255299 Submitted by: Jose Luis Duran Reported by: Jose Luis Duran MFC after: 1 week stand/forth/menu.4th | 6 +++++- stand/lua/drawer.lua | 5 ++++- 2 files changed, 9 insertions(+), 2 deletions(-) (In reply to Jose Luis Duran from comment #0) Thank you! A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=eabfffcb4c14751d1d2852ed82a1976b69854166 commit eabfffcb4c14751d1d2852ed82a1976b69854166 Author: Toomas Soome <tsoome@FreeBSD.org> AuthorDate: 2021-04-21 11:42:10 +0000 Commit: Toomas Soome <tsoome@FreeBSD.org> CommitDate: 2021-04-28 09:35:54 +0000 loader: do not output empty menu title As we output spaces around the menu title, we should also check, if the title is actually empty string. PR: 255299 Submitted by: Jose Luis Duran Reported by: Jose Luis Duran (cherry picked from 4ba91fa0736bb0672d475b6b56d9e7b06e78ff69) stand/forth/menu.4th | 6 +++++- stand/lua/drawer.lua | 5 ++++- 2 files changed, 9 insertions(+), 2 deletions(-) A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=ea03e7dbeea0d8287b83fb6f8e3c68e81abeba18 commit ea03e7dbeea0d8287b83fb6f8e3c68e81abeba18 Author: Toomas Soome <tsoome@FreeBSD.org> AuthorDate: 2021-04-21 11:42:10 +0000 Commit: Kyle Evans <kevans@FreeBSD.org> CommitDate: 2021-09-12 05:39:19 +0000 loader: do not output empty menu title As we output spaces around the menu title, we should also check, if the title is actually empty string. PR: 255299 Submitted by: Jose Luis Duran Reported by: Jose Luis Duran (cherry picked from commit 4ba91fa0736bb0672d475b6b56d9e7b06e78ff69) stand/forth/menu.4th | 6 +++++- stand/lua/drawer.lua | 5 ++++- 2 files changed, 9 insertions(+), 2 deletions(-) |
Created attachment 224328 [details] Fix empty loader_menu_title Commit 62ffcaab8f3ccba6053d4a5622c5ef2de9f636b5 introduced spaces around loader_menu_title. When set to an empty string (to not display a menu title), the spaces are still displayed. This patch adds a check to display the menu title only when is not an empty string.