Bug 255353
| Summary: | sysutils/hatop: Update to 0.8.1, Switch upstream (jhunt/hatop) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | mikeg | ||||
| Component: | Individual Port(s) | Assignee: | Rainer Hurling <rhurlin> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | rhurlin | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | Flags: | mikeg:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/jhunt/hatop/releases/tag/v0.8.1 | ||||||
| Attachments: |
|
||||||
^Triage: - [tags] in issue Titles are deprecated - Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval Attachment -> Details -> maintainer-approval [+] Thanks for the patch! Kubilay's entry of the keyword 'needs-qa' means that the submitter of a patch can significantly speed up the entire process to commit if the submitter itself already provides quality checks. Normally PR's with QA are committed and processed much faster by a committer. The least QA should do is to see if 'portlint -AC' still reports warnings or errors. It is better if the submitter also tests his patch with Poudriere to see if it builds and installs without errors in a clean environment. In this case, I have already taken over the PR and am running appropriate tests. In addition, I have already entered a link in the URL field, which contains the changes of the release :) But it is important, as already written by Kubilay, that the submitter sets the flag 'maintainer-approval' to '+'. So please set this flag in the attachments section, under details, thank you. Approval & feedback fields are set, Looks like I need to update my patch-submission workflows for future updates! (Since I already have to touch that to move it from svn to git the next update should be cleaner - can definitely tie portlint, should be able to get Poudriere going too since it's on the list anyway :-) A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=95958ea716ecccb626ea6731e46ce88e0b866737 commit 95958ea716ecccb626ea6731e46ce88e0b866737 Author: Rainer Hurling <rhurlin@FreeBSD.org> AuthorDate: 2021-04-27 16:15:16 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2021-04-27 16:15:16 +0000 sysutils/hatop: Update to 0.8.1 Changelog: https://github.com/jhunt/hatop/releases/tag/v0.8.1 PR: 255353 Submitted by: mikeg@bsd-box.net (maintainer) sysutils/hatop/Makefile | 15 +- sysutils/hatop/distinfo | 6 +- sysutils/hatop/files/patch-bin_hatop (gone) | 222 ---------------------------- sysutils/hatop/pkg-descr | 2 +- 4 files changed, 11 insertions(+), 234 deletions(-) Commited, thanks :) And good luck with revamping your patch-submission workflow. |
Created attachment 224390 [details] Patch 0.7.7 -> 0.8.1 Patch to move the port to an actively developed fork of hatop (github @ jhunt/hatop) & bring it current with the latest release (0.8.1) This change eliminates the local patch for Python 3 compatibility (the fork incorporates equivalent work). Tested OK on FreeBSD 12.2-p6 & Python 3.7 (python37-3.7.10)