Bug 255354

Summary:	devel/qt5-core Ignored by Synth
Product:	Ports & Packages	Reporter:	Chris Mangin <cmangin>
Component:	Individual Port(s)	Assignee:	freebsd-kde (group) <kde>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	adridg, matthias.pfaller
Priority:	---	Keywords:	needs-qa
Version:	Latest	Flags:	bugzilla: maintainer-feedback? (kde)
Hardware:	Any
OS:	Any
See Also:	https://github.com/jrmarino/synth/issues/191

Description Chris Mangin 2021-04-24 01:24:53 UTC

devel/qt5-core now looks for the file /etc/rc.d/os-release in base. If not present, it will add sysutils/etc_os-release as a runtime dependency but only for FreeBSD version < 13.0

This causes a problem is Synth, since that file does not exists in its chroot environment, so the port is now ignored if one is running FreeBSD 13 or later.

I've opened an issue upstream, since I'm not sure whether this should be fixed in the port itself or the port builder.

https://github.com/jrmarino/synth/issues/191

Comment 1 Matthias Pfaller 2021-04-26 07:32:14 UTC

I think the same thing will happen with sysutils/gnome-control-center. This too has a runtime dependency to sysutils/etc_os-release.

Comment 2 Adriaan de Groot freebsd_committer

2021-04-26 09:26:55 UTC

So this is a side-effect of the change introduced in PR 251073 .. I'll massage it to `&& before FreeBSD 13` so that builds with FreeBSD 13 and an incomplete world without depending on the os-release port.

Comment 3 commit-hook freebsd_committer

2021-04-26 14:39:22 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c237911a72ac5890045007e7929954a9d48eee96

commit c237911a72ac5890045007e7929954a9d48eee96
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2021-04-26 11:47:25 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2021-04-26 14:38:11 +0000

    [Qt, GNOME] Handle os-release a little more smartly

    Synth -- and therefore not all FreeBSD installations that *could*
    have an /etc/os-release, or that *ought* to have an os-release
    file at runtime -- doesn't have the RC script installed, so
    was triggering the "depend on ports os-release" clause.

    Partly revert, to checking for existence, but **also** assume
    that sufficiently-new 13 (or later) releases have os-release in
    base. This means that 12.2 (which ought to have it) will rely
    on base, while 12.1 and 11.4 and other legacy releases will
    rely on the port.

    PR:     255354 251073

 devel/qt5-core/Makefile                | 9 +++++++--
 sysutils/gnome-control-center/Makefile | 9 +++++++--
 2 files changed, 14 insertions(+), 4 deletions(-)

Comment 4 Adriaan de Groot freebsd_committer

2021-04-26 14:55:15 UTC

I'd suggest it's more of a Synth bug than anything else, but for now I've massaged the port to at least allow builds on 13-and-later in Synth to continue normally.