Summary: | net/gsocket needs RUN_DEPENDS= bash:shells/bash | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Stefan Grundmann <sg2342> |
Component: | Individual Port(s) | Assignee: | Alexey Dokuchaev <danfe> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | CC: | arr, danfe, ehaupt, lwhsu |
Priority: | --- | Flags: | lwhsu:
maintainer-feedback?
(arr) |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any |
Description
Stefan Grundmann
2021-04-26 08:10:18 UTC
(In reply to Stefan Grundmann from comment #0) Are those scripts compatible with /bin/sh? If so, we can replace the shebang line. (In reply to Li-Wen Hsu from comment #1) These scripts are not compatible with /bin/sh. I am ok with adding this dependency. Thank you for reporting it. How do you feel @lwhsu? (lwhsu@freebsd.org) (In reply to Andrew Reiter from comment #3) Yes this seems the right way to go. Can you create a patch for it? It would be nice to be created by git format-patch. (In reply to Li-Wen Hsu from comment #4) Definitely will do.. sg2342@googlemail.com if you have one already, just post it so it can be tested. Otherwise, I will make one in the next day or so. Thank you for pointing this out! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=bcf86b3dc26e59be6fa313ed2ce91a0423b311b6 commit bcf86b3dc26e59be6fa313ed2ce91a0423b311b6 Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2021-05-19 08:56:12 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2021-05-19 08:56:25 +0000 net/gsocket: add missing run-time dependency on GNU Bash This port installs a number of shell scripts riddled with bashisms, most notably, double bracket expressions, so fixing them to become POSIX shell-compliant does not look feasible or, rather, practical. While here, shorten the COMMENT without sacrificing its meaning so ``pkg search gsocket'' or ``pkg info | grep gsocket'' would fit in standard 80-character terminal and fix one minor whitespace nit. PR: 255409 net/gsocket/Makefile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) Committed with minor collateral improvements, thank you! (In reply to Alexey Dokuchaev from comment #7) Thank you for doing this... had a busy few weeks and this slipped through for me :-/. |