Bug 255743

Summary: devel/ipython: 7.23.1 fails to run: The 'matplotlib-inline' distribution was not found and is required by ipython
Product: Ports & Packages Reporter: p5B2EA84B3
Component: Individual Port(s)Assignee: Ruslan Makhmatkhanov <rm>
Status: Closed FIXED    
Severity: Affects Many People CC: lwhsu, python, rhurlin, rm, rsmith
Priority: --- Flags: koobs: merge-quarterly-
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
poudriere build log file none

Description p5B2EA84B3 2021-05-10 09:15:59 UTC 
Created attachment 224806 [details]
poudriere build log file

> ipython
Traceback (most recent call last):
  File "/usr/local/bin/ipython", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3243, in <module>
    def _initialize_master_working_set():
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3226, in _call_aside
    f(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3255, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 568, in _build_master
    ws.require(__requires__)
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 886, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 772, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'matplotlib-inline' distribution was not found and is required by ipython
Comment 1 rsmith 2021-05-11 17:46:10 UTC 
I can confirm the problem. (Python 3.9, 13.0-STABLE AMD64)

Looking at the setup.py of IPython, we are indeed missing a dependency;

install_requires = [
    "setuptools>=18.5",
    "jedi>=0.16",
    "decorator",
    "pickleshare",
    "traitlets>=4.2",
    "prompt_toolkit>=2.0.0,<3.1.0,!=3.0.0,!=3.0.1",
    "pygments",
    "backcall",
    "matplotlib-inline",
]

After cloning https://github.com/martinRenou/matplotlib-inline and installing it, IPython runs OK.
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2021-05-11 18:06:16 UTC 
(In reply to rsmith from comment #1)
Does installing the py38-matplotlib-inline-0.1.2 pkg also work?
Comment 3 rsmith 2021-05-11 21:25:32 UTC 
(In reply to Li-Wen Hsu from comment #2)

Yes, that also works.
I didn't realize there was already a port for it.

So that means that only the RUN_DEPENDS for IPython need to be adjusted.
Comment 4 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-05-12 09:21:28 UTC 
I'll take it
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-05-12 09:42:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=655a237422f8dfdda287a57c5e0fe61718b5c956

commit 655a237422f8dfdda287a57c5e0fe61718b5c956
Author:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
AuthorDate: 2021-05-12 09:40:47 +0000
Commit:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
CommitDate: 2021-05-12 09:40:47 +0000

    devel/ipython: add missing runtime dependency

    Add missing dependency upon matplotlib-inline, that was introduced
    in IPython 7.23 [1], but was overlooked in recent port update.

    [1] https://ipython.readthedocs.io/en/latest/whatsnew/version7.html?ipython-7-23#ipython-7-23

    PR:             255743
    Reported by:    p5B2E9A8F@t-online.de
    With hat:       python

 devel/ipython/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 6 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-05-12 09:44:54 UTC 
Committed, thank you!
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2021-05-13 01:04:48 UTC 
Is quarterly broken as well?
Comment 8 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-05-13 08:09:38 UTC 
(In reply to Kubilay Kocak from comment #7)

nope. it still at 7.22 according to freshports