Bug 255935

Created attachment 225008 [details]
Proposed patch

In lang/ecl, libatomic_ops is currently a BUILD_DEPENDS and not a LIB_DEPENDS. However, libatomic_ops is required at run time for COMPILE-FILE to work. For example:

;;;; hello.lisp
(format t "Hello, world!")

;;;; ecl
> (compile-file "hello.lisp")
;;; Loading #P"/usr/local/lib/ecl-20.4.24/cmp.fas"
;;;
;;; Compiling hello.lisp.
;;; OPTIMIZE levels: Safety=2, Space=0, Speed=3, Debug=0
;;;
;;; End of Pass 1.
;;; Internal error:
;;;   ** Error code 1 when executing
;;; (EXT:RUN-PROGRAM "cc" ("-I." "-I/usr/local/include/" "-isystem" "/usr/local/include" "-I/usr/local/include" "-O2" "-pipe" "-fstack-protector-strong" "-isystem" "/usr/local/include" "-fno-strict-aliasing" "-std=c99" "-fPIC" "-Dfreebsd" "-O2" "-c" "hello.c" "-o" "hello.o")):
;;; In file included from hello.c:5:
;;; In file included from /usr/local/include/ecl/ecl-cmp.h:33:
;;; In file included from /usr/local/include/ecl/ecl.h:89:
;;; In file included from /usr/local/include/ecl/stacks.h:23:
;;; /usr/local/include/ecl/ecl_atomics.h:23:12: fatal error: 'atomic_ops.h' file not found
;;; #  include <atomic_ops.h>
;;;            ^~~~~~~~~~~~~~
;;; 1 error generated.

The proposed patch (attached) makes libatomic_ops a LIB_DEPENDS.