Bug 255981
| Summary: | sysutils/zrepl: pidfile should be world-readable | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Alan Somers <asomers> | ||||||
| Component: | Individual Port(s) | Assignee: | Lewis Cook <lcook> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | lcook, lwhsu, raul.munoz | ||||||
| Priority: | --- | Flags: | asomers:
maintainer-feedback?
(lcook) lcook: merge-quarterly+ |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256472 | ||||||||
| Attachments: |
|
||||||||
Sorry, due to a lack of time I have reset the maintainer of this port back to ports@FreeBSD.org. Hopefully someone else is able to step in to help. Resetting the assignee of this bug accordingly. lcook, could you please review this patch? (In reply to Alan Somers from comment #2) Sorry for the delay, been much busier than anticipated. Seems a good idea to include this change and I have no objections, I'll commit this and MFH back into 2021Q2. Thank you Alan! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2a866a1b4fd0e2ce6d07904c920f98e7d994bd59 commit 2a866a1b4fd0e2ce6d07904c920f98e7d994bd59 Author: Alan Somers <asomers@FreeBSD.org> AuthorDate: 2021-06-04 10:15:57 +0000 Commit: Lewis Cook <lcook@FreeBSD.org> CommitDate: 2021-06-04 10:21:49 +0000 sysutils/zrepl: pidfile should be world-readable PR: 255981 sysutils/zrepl/Makefile | 1 + sysutils/zrepl/files/zrepl.in | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) A commit in branch 2021Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=073656063b7ce50ecfb7851bdc02966eb54d783b commit 073656063b7ce50ecfb7851bdc02966eb54d783b Author: Alan Somers <asomers@FreeBSD.org> AuthorDate: 2021-06-04 10:15:57 +0000 Commit: Lewis Cook <lcook@FreeBSD.org> CommitDate: 2021-06-04 10:24:14 +0000 sysutils/zrepl: pidfile should be world-readable PR: 255981 (cherry picked from commit 2a866a1b4fd0e2ce6d07904c920f98e7d994bd59) sysutils/zrepl/Makefile | 1 + sysutils/zrepl/files/zrepl.in | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) Committed, thanks! Thanks, lcook! Created attachment 225629 [details]
/var/run/zrepl.pid
Don't forget /var/run/zrepl ;)
|
Created attachment 225074 [details] Change permissions on /var/run/zrepl to 755 zrepl writes /var/run/zrepl/daemon.pid . But curiously, it creates the /var/run/zrepl directory with 700 permissions. That prevents non-root users from doing "service zrepl status". I don't see any sensitive files instead of that directory. Is there any reason it can't be made 755?