Bug 256201
| Summary: | sysutils/fusefs-ntfs: delete obsolete patch to lowntfs-3g.c | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Alan Somers <asomers> | ||||
| Component: | Individual Port(s) | Assignee: | Alexey Dokuchaev <danfe> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | danfe, fernape, freebsd | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(freebsd) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
^Triage: Reporter is committer, assign accordingly. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f3c7a7686768351238894670b203c28526d247c1 commit f3c7a7686768351238894670b203c28526d247c1 Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2022-05-24 01:52:14 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2022-05-24 01:52:14 +0000 sysutils/fusefs-ntfs: prune two obsolete patches from the port They still apply, but serve no purpose now, and can be deleted. PR: 256198, 256201 .../files/patch-libntfs-3g__device.c (gone) | 56 ---------------------- .../files/patch-src__lowntfs-3g.c (gone) | 17 ------- 2 files changed, 73 deletions(-) ^Triage: Assign to committer that resolved |
Created attachment 225320 [details] Delete an obsolete patch. sysutils/fusefs-ntfs patches src/lowntfs-3g.c to remove the return action from ntfs_fuse_bmap. But that function cannot possibly work correctly in the patched form. It _must_ call either fuse_reply_err or fuse_reply_bmap, or else the fusefs driver will leak commands and user threads will hang. This patch was added in 2010, so I'm guessing that ports' copy of libfuse in 2010 lacked bmap support. That would explain the necessity of the patch. However, it serves no purpose now, and can be deleted. I have build tested this in Poudriere for amd64 13.0, 12.2, and 11.4. But I haven't done any runtime testing.