Summary: | devel/efl: efreetd crashes with "Abort trap", thus application menu icons disappear | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Euan Thoms <euan> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-enlightenment (Nobody) <enlightenment> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Many People | CC: | arrowd, peter | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(enlightenment) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Euan Thoms
2021-06-04 09:15:59 UTC
I've asked the opinion of developers of EFL. Please, stay tuned :) The answer from Carsten Haitzler: oh > 1024 fd's ... with ye olde select. yeah. that may have issues. I can throw this into git master. for now carrying a patch in the bsd package builds would be the right thing. the fix will then be in the next efl release. I'll try to patch the port in the next days. Thank you so much Peter. I'm so glad to this getting taken seriously by upstream, and the response time is amazing. I had a feeling this bug was affecting users for a long time. I've seen so many reports of strange efreetd behaviour by Enlightenment users over the last few years. I thought it was more widespread than just the BSD's. That's one of the reasons I kept going with this most difficult bug to track down. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=393b0d030716b82e62737556abd22ab71f6aef93 commit 393b0d030716b82e62737556abd22ab71f6aef93 Author: Gleb Popov <arrowd@FreeBSD.org> AuthorDate: 2021-06-04 16:39:30 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2021-06-04 16:43:20 +0000 devel/efl: Add a workaround for efreetd crash. PR: 256408 Tested by: Euan Thoms <euan@potensol.com> devel/efl/Makefile | 2 +- devel/efl/files/patch-src_lib_ecore_ecore__main.c (new) | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) (In reply to Euan Thoms from comment #3) Pushed in, thank you. > I had a feeling this bug was affecting users for a long time. And AFAIK, you're not mistaken. > That's one of the reasons I kept going with this most difficult bug to track down. This is greatly appreciated. If you're still up to it, you might want to implement a correct fix to this issue - use kqueue/kevent mechanism, which is much more performant and scalable compared to select(). EFL probably already have some sort of wrapper for Linux epoll and BSD kevent, so this shouldn't be too hard. (In reply to Gleb Popov from comment #5) > EFL probably already have some sort of wrapper for Linux epoll and BSD kevent, so this shouldn't be too hard. I'll try to take a look into it if I get some time. Whilst I more or less know what kqueue is/does, I have not coded with it before. But I'd like to learn. |